Skip to content

Commit

Permalink
Merge branch 'master' into repopermsfix
Browse files Browse the repository at this point in the history
  • Loading branch information
achantavy committed Jul 22, 2024
2 parents b868934 + 73996e9 commit 2e358d9
Showing 1 changed file with 9 additions and 11 deletions.
20 changes: 9 additions & 11 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,15 @@
- https://github.com/lyft/cartography/issues/...


### Proof that this works
> We can merge your change in faster if we see that it works. For example, if making a change to the graph, include a
> screenshot showing what the graph looked like before and after your changes. You can also include console log traces
> showing what happened before and after your changes.


### Checklist

- [ ] Update/add unit or integration tests
Provide proof that this works (this makes reviews move faster). Please perform one or more of the following:
- [ ] Update/add unit or integration tests.
- [ ] Include a screenshot showing what the graph looked like before and after your changes.
- [ ] Include console log trace showing what happened before and after your changes.

If you are changing a node or relationship:
- [ ] Update the [schema](https://github.com/lyft/cartography/tree/master/docs/root/modules) and [readme](https://github.com/lyft/cartography/blob/master/docs/schema/README.md).

If you are modifying or implementing an intel module:
- [ ] Update the [schema](https://github.com/lyft/cartography/tree/master/docs/root/modules) and [readme](https://github.com/lyft/cartography/blob/master/docs/schema/README.md)
- [ ] Use the NodeSchema [data model](https://lyft.github.io/cartography/dev/writing-intel-modules.html#defining-a-node)
If you are implementing a new intel module:
- [ ] Use the NodeSchema [data model](https://lyft.github.io/cartography/dev/writing-intel-modules.html#defining-a-node).

0 comments on commit 2e358d9

Please sign in to comment.