Skip to content

Commit

Permalink
Merge branch 'master' into ramonpetgrave64-patch-1
Browse files Browse the repository at this point in the history
  • Loading branch information
chandanchowdhury committed Jun 26, 2024
2 parents 68687b3 + 07243c2 commit 4473a50
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions MAINTAINERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ List of community members who have shown they are committed to Cartography's con
- Marco Lancini (https://github.com/marco-lancini): Deployment and use-cases
- Kedar Ghule (https://github.com/kedarghule): Plugin development
- Purusottam Mupunu (https://https://github.com/mpurusottamc): Deployment and use-cases
- Chandan Chowdhury (https://github.com/chandanchowdhury): Plugin development


## Friends of Cartography
Expand Down
2 changes: 1 addition & 1 deletion cartography/intel/azure/compute.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def load_vms(neo4j_session: neo4j.Session, subscription_id: str, vm_list: List[D
v.resourcegroup = vm.resource_group
SET v.lastupdated = $update_tag, v.name = vm.name,
v.plan = vm.plan.product, v.size = vm.hardware_profile.vm_size,
v.license_type=vm.license_type, v.computer_name=vm.os_profile.computer_ame,
v.license_type=vm.license_type, v.computer_name=vm.os_profile.computer_name,
v.identity_type=vm.identity.type, v.zones=vm.zones,
v.ultra_ssd_enabled=vm.additional_capabilities.ultra_ssd_enabled,
v.priority=vm.priority, v.eviction_policy=vm.eviction_policy
Expand Down
4 changes: 2 additions & 2 deletions cartography/intel/crowdstrike/endpoints.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ def load_host_data(
)


def get_host_ids(client: Hosts) -> List[List[str]]:
def get_host_ids(client: Hosts, crowdstrikeapi_filter: str = '', crowdstrikeapi_limit: int = 5000) -> List[List[str]]:
ids = []
parameters = {"filter": 'service_provider:"AWS_EC2"', "limit": 400}
parameters = {"filter": crowdstrikeapi_filter, "limit": crowdstrikeapi_limit}
response = client.QueryDevicesByFilter(parameters=parameters)
body = response.get("body", {})
resources = body.get("resources", [])
Expand Down

0 comments on commit 4473a50

Please sign in to comment.