Skip to content

Commit

Permalink
shorten
Browse files Browse the repository at this point in the history
  • Loading branch information
ramonpetgrave64 authored and achantavy committed Jul 20, 2024
1 parent 9544ebf commit 507f772
Showing 1 changed file with 4 additions and 12 deletions.
16 changes: 4 additions & 12 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,11 @@ Read through our [developer docs](https://lyft.github.io/cartography/dev/develop
- [ ] PR Title starts with "Fixes: [issue number]"

If you are modifying or implementing a new intel module
- [ ] Update the [schema](https://github.com/lyft/cartography/tree/master/docs/root/modules)
- [ ] Update the [schema](https://github.com/lyft/cartography/tree/master/docs/root/modules) and [readme](https://github.com/lyft/cartography/blob/master/docs/schema/README.md)
- [ ] Use our NodeSchema [data model](https://lyft.github.io/cartography/dev/writing-intel-modules.html#defining-a-node)
- [ ] Use specialized functions
- [ ] `get_` to [fetch](https://lyft.github.io/cartography/dev/writing-intel-modules.html#get) the data
- [ ] `transform_` do [modifications](https://lyft.github.io/cartography/dev/writing-intel-modules.html#transform) against the data
- [ ] `load_` begin the database [write](https://lyft.github.io/cartography/dev/writing-intel-modules.html#load) transactions
- [ ] `cleanup_` to [remove](https://lyft.github.io/cartography/dev/writing-intel-modules.html#cleanup) stale nodes and relationships
- [ ] Use specialized functions `get_`, `transform_`, `load_`, and `cleanup_` functions
- [ ] Add [tests](https://lyft.github.io/cartography/dev/writing-intel-modules.html#making-tests)
- [ ] Unit tests
- [ ] Test your `transform_` function with sample data
- [ ] Unit tests: Test your `transform_` function with sample data
- [ ] Integration tests
- [ ] Use our test [helper functions](https://github.com/lyft/cartography/blob/master/tests/integration/util.py)
- [ ] Test that the new nodes are created
- [ ] Check the the new relationships are created
- [ ] Check that stale nodes will be removed
- [ ] Check that stale relationships will be removed
- [ ] Test a cleanup job

0 comments on commit 507f772

Please sign in to comment.