Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #1298 - Add SnipeIT source #1299

Merged
merged 30 commits into from
Aug 21, 2024

Conversation

chandanchowdhury
Copy link
Collaborator

@chandanchowdhury chandanchowdhury commented Apr 26, 2024

Summary

Adding new intel module for SnipeIT source.

Related issues

#1298


Read through our developer docs

  • PR Title starts with "Fixes: [issue number]"

If you are modifying or implementing a new intel module

  • Update the schema and readme
  • Use our NodeSchema data model
  • Use specialized functions get_, transform_, load_, and cleanup_ functions
  • Add tests
    • Unit tests: Test your transform_ function with sample data (Not applicable)
    • Integration tests

@chandanchowdhury chandanchowdhury marked this pull request as ready for review April 26, 2024 21:24
@chandanchowdhury chandanchowdhury changed the title Snipeit support Add Snipeit source Apr 29, 2024
@chandanchowdhury
Copy link
Collaborator Author

Review request

@achantavy

@chandanchowdhury chandanchowdhury changed the title Add Snipeit source Fixes: #1298 - Add SnipeIT source Jun 14, 2024
@chandanchowdhury chandanchowdhury added the data-addition Describes adding new data to the graph label Jun 30, 2024
@chandanchowdhury chandanchowdhury requested review from heryxpc and achantavy and removed request for heryxpc July 18, 2024 17:59
@chandanchowdhury chandanchowdhury enabled auto-merge (squash) July 18, 2024 18:01
Copy link
Contributor

@achantavy achantavy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits but looks good

cartography/intel/snipeit/asset.py Outdated Show resolved Hide resolved
cartography/intel/snipeit/util.py Show resolved Hide resolved
cartography/intel/snipeit/util.py Show resolved Hide resolved
docs/root/modules/snipeit/config.md Show resolved Hide resolved
docs/root/modules/snipeit/schema.md Outdated Show resolved Hide resolved
docs/root/modules/snipeit/schema.md Outdated Show resolved Hide resolved
@chandanchowdhury chandanchowdhury merged commit 860fdb3 into lyft:master Aug 21, 2024
5 checks passed
@chandanchowdhury chandanchowdhury deleted the snipeit branch August 21, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-addition Describes adding new data to the graph
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants