Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend update probes #2703

Merged

Conversation

fran2344
Copy link
Contributor

Backend update probes with validation attributes

Description

Adding update method to update liveness and readiness probes.

#2702

No frontend changes

Testing Performed

curl -X POST http://localhost:8080/v1/k8s/updateDeployment
-H 'Content-Type: application/json' 
--data 
'{"clientset": "clientset", 
"cluster": "mycluster",
"namespace": "default", 
"name": "two-container-app", 
"fields": 
{ 
"containerProbes": 
[
{"containerName": "container2", 
"readinessProbe": 
  {"initialDelaySeconds": "6", "periodSeconds": "4" }
}]}}'

@fran2344 fran2344 requested a review from a team as a code owner June 23, 2023 01:53
backend/service/k8s/deployment.go Outdated Show resolved Hide resolved
backend/service/k8s/deployment_test.go Outdated Show resolved Hide resolved
backend/service/k8s/deployment_test.go Outdated Show resolved Hide resolved
backend/service/k8s/deployment_test.go Outdated Show resolved Hide resolved
@mikecutalo mikecutalo merged commit 451d5bd into lyft:main Jul 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants