k8s: replace usage of clusterName to for k8s upgrade #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecutalo
changed the title
mikecutalo
commented
Jun 23, 2023
mikecutalo
commented
Jun 23, 2023
| @@ -94,49 +90,3 @@ func TestApplyListOptions(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func TestApplyClusterMetadata(t *testing.T) { | |||
There was a problem hiding this comment.
I simply moved this test to kube_cluster_test.go
samrabelachew
approved these changes
Jun 26, 2023
scarlettperry
approved these changes
Jun 26, 2023
smonero
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clutch relies on cluster information throughout the application, previously we relied on the clusterName field on the objectmeta which has since been deprecated.
To replace this we utilize our own label
cluster.clutch.sh/nameto denote which cluster the object belongs to, these helper functions are used to standardize the getting and setting of this field.This unblocks our ability to upgrade to the latest k8s client.
Testing Performed
Unit