Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend: Autocomplete Adjustments #2708

Merged
merged 2 commits into from
Jun 29, 2023
Merged

frontend: Autocomplete Adjustments #2708

merged 2 commits into from
Jun 29, 2023

Conversation

jdslaugh
Copy link
Contributor

Description

Makes modifications to autocomplete onReturn flow as well as the ProjectSelector usage of it to fix autocomplete issues.

  • modifies the onReturn caller to be a debounced version so it doesn't call it multiple times from pressing enter or selecting from a dropdown
  • Will fire an onChange event for onReturn so that when selecting an item from the dropdown it doesn't submit with what is currently typed in
  • Adds form handling for the ProjectSelector to correctly grab the field and adds an onReturn so that it can fire when selecting something from the dropdown

Testing Performed

manual

@jdslaugh jdslaugh requested a review from a team as a code owner June 28, 2023 19:31
@jdslaugh jdslaugh merged commit 5a61fb7 into main Jun 29, 2023
@jdslaugh jdslaugh deleted the autocomplete-patch branch June 29, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelmolina95 miguelmolina95 miguelmolina95 approved these changes

@jecr jecr jecr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdslaugh @jecr @miguelmolina95