proxy config: support path regex in allowed requests #2731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarlettperry
changed the title
scarlettperry
changed the title
scarlettperry
commented
Jul 18, 2023
backend/module/proxy/proxy.go
Outdated
Comment on lines
42
to
44
| case *proxyv1cfg.AllowRequest_Path: | ||
| // For exact path type, validate that each services constructs a parsable URL | ||
| _, err := url.Parse(fmt.Sprintf("%s%s", service.Host, t.Path)) |
There was a problem hiding this comment.
decided to just do this validation when it's an exact path type as a path regex might contain characters like ^ which would fail url.Parse
mikecutalo
reviewed
Jul 18, 2023
smonero
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
currently we perform isallowedRequest on each proxy API request to confirm the request path exactly matches an allowed request path in the proxy config. this set up works for paths with query parameters (i.e.
/car?brand=foo) but not path parameters (ie/car/{brand}).PR adds support in the proxy config to specify either an exact path or a path regex. If it's the latter, in
isallowedRequestwe check if the request path string matches the path regex.Note: the updates to the config are backwards compatible and won't need to modify existing use cases of
path.Testing Performed
manually
unit tests