Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVCON-6293] add first timestamp #2737

Merged
merged 1 commit into from
Jul 18, 2023
Merged

[DEVCON-6293] add first timestamp #2737

merged 1 commit into from
Jul 18, 2023

Conversation

smonero
Copy link
Contributor

@smonero smonero commented Jul 18, 2023

Description

Testing Performed

GitHub Issue

Fixes #

TODOs

@smonero smonero requested a review from a team as a code owner July 18, 2023 00:33
@smonero smonero changed the title add first timestamp [DEVCON-6293] add first timestamp Jul 18, 2023
@@ -1303,6 +1303,8 @@ message Event {

// last timestamp is the most recent time the event occurred (which can be different from the first time)
int64 last_timestamp_millis = 12;

int64 first_timestamp_millis = 13;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: code comment

@smonero smonero merged commit 1be8a25 into main Jul 18, 2023
@smonero smonero deleted the firstTimestamp branch July 18, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants