Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

Merge from kubeflow/katib #13

Open
wants to merge 1,228 commits into
base: master
Choose a base branch
from
Open

Merge from kubeflow/katib #13

wants to merge 1,228 commits into from

Conversation

mayankjuneja
Copy link

No description provided.

@mayankjuneja
Copy link
Author

meow @vinaykakade
Syncing master with open source katib master.

orfeas-k and others added 29 commits October 24, 2022 14:38
Signed-off-by: Orfeas Kourkakis <[email protected]>

Signed-off-by: Orfeas Kourkakis <[email protected]>
Signed-off-by: tenzen-y <[email protected]>

Signed-off-by: tenzen-y <[email protected]>
* Fix Katib unit tests.

Signed-off-by: Elena Zioga <[email protected]>

Signed-off-by: Elena Zioga <[email protected]>
Bumps [jose](https://github.com/panva/jose) from 2.0.5 to 2.0.6.
- [Release notes](https://github.com/panva/jose/releases)
- [Changelog](https://github.com/panva/jose/blob/v2.0.6/CHANGELOG.md)
- [Commits](panva/jose@v2.0.5...v2.0.6)

---
updated-dependencies:
- dependency-name: jose
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1825)

Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](unshiftio/url-parse@1.5.3...1.5.10)

---
updated-dependencies:
- dependency-name: url-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.4.7 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](unshiftio/url-parse@1.4.7...1.5.10)

---
updated-dependencies:
- dependency-name: url-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
)

Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md)
- [Commits](caolan/async@v2.6.3...v2.6.4)

---
updated-dependencies:
- dependency-name: async
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md)
- [Commits](caolan/async@v2.6.3...v2.6.4)

---
updated-dependencies:
- dependency-name: async
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#1835)

Bumps [lodash-es](https://github.com/lodash/lodash) from 4.17.11 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.11...4.17.21)

---
updated-dependencies:
- dependency-name: lodash-es
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.14 to 6.3.16.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](karma-runner/karma@v6.3.14...v6.3.16)

---
updated-dependencies:
- dependency-name: karma
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1880)

Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/EventSource/eventsource/releases)
- [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md)
- [Commits](EventSource/eventsource@v1.1.0...v1.1.1)

---
updated-dependencies:
- dependency-name: eventsource
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1.
- [Release notes](https://github.com/terser/terser/releases)
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/commits)

---
updated-dependencies:
- dependency-name: terser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.0.7 to 1.1.2.
- [Release notes](https://github.com/EventSource/eventsource/releases)
- [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md)
- [Commits](EventSource/eventsource@v1.0.7...v1.1.2)

---
updated-dependencies:
- dependency-name: eventsource
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [got](https://github.com/sindresorhus/got) from 11.7.0 to 11.8.5.
- [Release notes](https://github.com/sindresorhus/got/releases)
- [Commits](sindresorhus/got@v11.7.0...v11.8.5)

---
updated-dependencies:
- dependency-name: got
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ansi-regex](https://github.com/chalk/ansi-regex), [ansi-regex](https://github.com/chalk/ansi-regex) and [ansi-regex](https://github.com/chalk/ansi-regex). These dependencies needed to be updated together.

Updates `ansi-regex` from 5.0.0 to 5.0.1
- [Release notes](https://github.com/chalk/ansi-regex/releases)
- [Commits](chalk/ansi-regex@v5.0.0...v5.0.1)

Updates `ansi-regex` from 4.1.0 to 5.0.1
- [Release notes](https://github.com/chalk/ansi-regex/releases)
- [Commits](chalk/ansi-regex@v5.0.0...v5.0.1)

Updates `ansi-regex` from 3.0.0 to 5.0.1
- [Release notes](https://github.com/chalk/ansi-regex/releases)
- [Commits](chalk/ansi-regex@v5.0.0...v5.0.1)

---
updated-dependencies:
- dependency-name: ansi-regex
  dependency-type: indirect
- dependency-name: ansi-regex
  dependency-type: indirect
- dependency-name: ansi-regex
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Removes [ansi-html](https://github.com/Tjatse/ansi-html). It's no longer used after updating ancestor dependency [react-scripts](https://github.com/facebook/create-react-app/tree/HEAD/packages/react-scripts). These dependencies need to be updated together.


Removes `ansi-html`

Updates `react-scripts` from 3.2.0 to 5.0.1
- [Release notes](https://github.com/facebook/create-react-app/releases)
- [Changelog](https://github.com/facebook/create-react-app/blob/main/CHANGELOG-3.x.md)
- [Commits](https://github.com/facebook/create-react-app/commits/[email protected]/packages/react-scripts)

---
updated-dependencies:
- dependency-name: ansi-html
  dependency-type: indirect
- dependency-name: react-scripts
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* UI: Make KWA's main table responsive and add toolbar

* Add a top row toolbar with the title of the app and the button to
  create a new Experiment.
* Replace the card with a responsive table that shows the items. The
  component also has a paginator.

Signed-off-by: Elena Zioga <[email protected]>

* build: Update Dockerfile and README file

Update Dockerfile and README file to check out to the commit in master
branch from the Kubeflow repository that includes the corresponding
changes.

Signed-off-by: Elena Zioga <[email protected]>

Signed-off-by: Elena Zioga <[email protected]>
Signed-off-by: tenzen-y <[email protected]>

Signed-off-by: tenzen-y <[email protected]>
…1990)

* Move the status column to the first position of the trials table as
  it is in the other tables.

Signed-off-by: Elena Zioga <[email protected]>

Signed-off-by: Elena Zioga <[email protected]>
* Update training operator image in CI

* Remove deprecated GRPC var

* Remove deprecated GRPC var

* Remove deprecated GRPC var

* Support for k8s v1.25 in CI

* Revert "Support for k8s v1.25 in CI"

This reverts commit 16e6fe4.
…/setup-python version (#1996)

* [chore] Upgrade docker/metadata-action to v4

Signed-off-by: tenzen-y <[email protected]>

* [chore] Upgrade actions/checkout to v3

Signed-off-by: tenzen-y <[email protected]>

* [chore] Upgrade action/setup-python version to v4

Signed-off-by: tenzen-y <[email protected]>

Signed-off-by: tenzen-y <[email protected]>
* Support for k8s v1.25 in CI

* Revert "Support for k8s v1.25 in CI"

This reverts commit 16e6fe4.

* Support for k8s v1.25 in CI

* Support for k8s v1.25 in CI

* Support for k8s v1.25 in CI

* Add Readme changes
* Rename the Age header to Created at and right align it.

Signed-off-by: Elena Zioga <[email protected]>

Signed-off-by: Elena Zioga <[email protected]>
…#2003)

Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.1.
- [Release notes](https://github.com/webpack/loader-utils/releases)
- [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.1/CHANGELOG.md)
- [Commits](webpack/loader-utils@v1.4.0...v1.4.1)

---
updated-dependencies:
- dependency-name: loader-utils
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
andreyvelich and others added 30 commits June 25, 2024 16:26
)

* doc: initial commit of gsoc proposal(project 6).

Signed-off-by: Electronic-Waste <[email protected]>

* doc: complete KEP for gsoc proposal(Project 6).

Signed-off-by: Electronic-Waste <[email protected]>

* chore: add non-goals and examples.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: add .

Signed-off-by: Electronic-Waste <[email protected]>

* chore: add compatibility changes in trial controller.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: update architecture figure.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: update format.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: update doc after the review in 10th, June.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: add code link and remove namespace env variable.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: modify proposal after the review in 14th, June.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: delete WIP label.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: add timeout param into report_metrics.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: metrics_collector_config spelling.

Signed-off-by: Electronic-Waste <[email protected]>

---------

Signed-off-by: Electronic-Waste <[email protected]>
* chore: add report_metrics.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: modify the code according to the first review.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: add validation for metrics value & rename katib_report_metrics.py to report_metrics.py.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: update import path in __init__.py.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: delete blank line.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: update RuntimeError doc string & correct spelling error & add new line.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: delete blank in the last line.

Signed-off-by: Electronic-Waste <[email protected]>

---------

Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Andrey Velichkevich <[email protected]>
implmentation -> implementation

Signed-off-by: Ikko Ashimine <[email protected]>
* Begin enabling pre-commit hooks

Signed-off-by: droctothorpe <[email protected]>

* Address PR feedback

Signed-off-by: droctothorpe <[email protected]>

---------

Signed-off-by: droctothorpe <[email protected]>
* chore: add metrics_collector_config in tune function.

Signed-off-by: Electronic-Waste <[email protected]>

* rebase: rebase feat/new-param-tune to master.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: add metrics collector kind list in comment.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: always pass Trial name to the training container.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: delete passing env variable logics in katib_client.py

Signed-off-by: Electronic-Waste <[email protected]>

* fix: passing env variable KATIB_TRIAL_NAME in the webhook of pod.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: pass env variable KATIB_TRIAL_NAME only to the primary container.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: add report_metrics in post_gen.py.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: change nil error to allErrs(deleted by accident).

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix lint error in inject_webhook.go.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: wrap env variables passing logics into mutatePodEnv.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: add unit tests for mutatePodEnv.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: delete protocmp.

Signed-off-by: Electronic-Waste <[email protected]>

---------

Signed-off-by: Electronic-Waste <[email protected]>
…uf/testing/protocmp`. (#2391)

Signed-off-by: Electronic-Waste <[email protected]>
* create llm hyperparameters tuning api proposal

Signed-off-by: helenxie-bit <[email protected]>

* update llm hyperparameters tuning api proposal

Signed-off-by: helenxie-bit <[email protected]>

* update proposal

Signed-off-by: helenxie-bit <[email protected]>

* fix some typos

Signed-off-by: helenxie-bit <[email protected]>

* update the path of image and delete parameter 'resouces_per_worker' from tune api

Signed-off-by: helenxie-bit <[email protected]>

* delete objective function and adjust the design of tune API

Signed-off-by: helenxie-bit <[email protected]>

* Update docs/proposals/llm-hyperparameter-optimization-api.md

Co-authored-by: Andrey Velichkevich <[email protected]>
Signed-off-by: helenxie-bit <[email protected]>

* Move 'Advanced Functionalities' to 'Non-Goals', and update 'Implementation' part

Signed-off-by: helenxie-bit <[email protected]>

* update 'pytorch_config'

Signed-off-by: helenxie-bit <[email protected]>

* change the name of 'pytorch_config' to 'resources_per_trial'

Signed-off-by: helenxie-bit <[email protected]>

* adjust format

Signed-off-by: helenxie-bit <[email protected]>

* adjust format

Signed-off-by: helenxie-bit <[email protected]>

* adjust format

Signed-off-by: helenxie-bit <[email protected]>

* update implementation part and the type of 'resources_per_trial'

Signed-off-by: helenxie-bit <[email protected]>

* update the example

Signed-off-by: helenxie-bit <[email protected]>

* update 'resources_per_trial'& add one more option for defining objective function

Signed-off-by: helenxie-bit <[email protected]>

* fix typo errors

Signed-off-by: helenxie-bit <[email protected]>

* delete 'WIP' tag

Signed-off-by: helenxie-bit <[email protected]>

* update example

Signed-off-by: helenxie-bit <[email protected]>

* update example

Signed-off-by: helenxie-bit <[email protected]>

* update example

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

---------

Signed-off-by: helenxie-bit <[email protected]>
Co-authored-by: Andrey Velichkevich <[email protected]>
…mpatible (#2400)

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 24.0.9+incompatible to 26.1.4+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v24.0.9...v26.1.4)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Shashank Mittal <[email protected]>

modified feasibleSpace

Removed Categorical from Distribution
Signed-off-by: Shashank Mittal <[email protected]>

modified feasibleSpace

refactored proposal based on comments

comparison table updated

extra heading removed
* fix(sdk): fix error field metrics_collector in tune function.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): Add e2e tests for tune function.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): add missing field parameters.

Signed-off-by: Electronic-Waste <[email protected]>

* refactor(test/sdk): add run-e2e-tune-api.py.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): delete tune testing code in run-e2e-experiment.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): add blank lines.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): add verbose and temporarily delete e2e-experiment test.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): add namespace_labels.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): add time.sleep(5).

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): add error output.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): build random image for tune.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): delete extra debug log.

Signed-off-by: Electronic-Waste <[email protected]>

* refactor(test/sdk): create separate workflow for tune.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): change api to API.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): change the permission of scripts.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): delete exit code & comment image pulling.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): delete image pulling phase.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): refactor workflow file to use template.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): mark experiments and trial-images as not required.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): pass tune-api param to setup-minikube.sh.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): fix err in template-e2e-test.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): add debug logs.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): reorder params and delete logs.

Signed-off-by: Electronic-Waste <[email protected]>

---------

Signed-off-by: Electronic-Waste <[email protected]>
…mpatible (#2405)

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 26.1.4+incompatible to 26.1.5+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v26.1.4...v26.1.5)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add black formater and flake8 linter to pre-commit

Also add's the flake8 config file

Signed-off-by: Ignas Baranauskas <[email protected]>

* Fixes black formating

Signed-off-by: Ignas Baranauskas <[email protected]>

* Fixes flake8 linting errors

Signed-off-by: Ignas Baranauskas <[email protected]>

---------

Signed-off-by: Ignas Baranauskas <[email protected]>
…uide (#2401)

* test(webhook): save current work.

Signed-off-by: Electronic-Waste <[email protected]>

* refactor(test/webhook): refactor inject_webhook_test.go.

Signed-off-by: Electronic-Waste <[email protected]>

* test(webhook): fix lint error.

Signed-off-by: Electronic-Waste <[email protected]>

* test(webhook): add UT deleted by accident.

Signed-off-by: Electronic-Waste <[email protected]>

---------

Signed-off-by: Electronic-Waste <[email protected]>
…on client (#2403)

* added Unknown distribution and convertDistribution in suggestion client

added unit tests

Signed-off-by: Shashank Mittal <[email protected]>

* removed custom compare func

Signed-off-by: Shashank Mittal <[email protected]>

---------

Signed-off-by: Shashank Mittal <[email protected]>
* introduced error constants and replaced reflect with cmp

Signed-off-by: tariq-hasan <[email protected]>

* fix order of mock method calls

Signed-off-by: tariq-hasan <[email protected]>

---------

Signed-off-by: tariq-hasan <[email protected]>
* added validator for feasible space distribution

Signed-off-by: Shashank Mittal <[email protected]>

validation logic fixed

added unit test

added unit test for valid distribution

requested changes made

Update pkg/webhook/v1beta1/experiment/validator/validator.go

Co-authored-by: Yuki Iwai <[email protected]>

fmt

* fmt fix

Signed-off-by: Shashank Mittal <[email protected]>

---------

Signed-off-by: Shashank Mittal <[email protected]>
… dir for black and flake8 (#2413)

* Chnage the isort profile to black, and add pkg dir for black and flake8

Signed-off-by: Ignas Baranauskas <[email protected]>

* Fix the formating

Signed-off-by: Ignas Baranauskas <[email protected]>

* Fix flake8 lint issues

Signed-off-by: Ignas Baranauskas <[email protected]>

---------

Signed-off-by: Ignas Baranauskas <[email protected]>
* fix: fix bugs in report_metrics.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix bugs in tune.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix bugs in get_trial_metrics.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: update .gitignore and setup.py.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: update Makefile.

Signed-off-by: Electronic-Waste <[email protected]>

* feat: add report_metrics_test.py.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix lint error.

Signed-off-by: Electronic-Waste <[email protected]>

* feat: add UTs for get_trial_metrics.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: update post_gen.py.

Signed-off-by: Electronic-Waste <[email protected]>

* refactor: rebase to master.

Signed-off-by: Electronic-Waste <[email protected]>

* test(sdk): use single katib_client.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(sdk): add TODO for import rewrite.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(sdk): fix lint error with black.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(sdk): fix lint error with isort.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(sdk): reformat import in katib_client_test.py.

Signed-off-by: Electronic-Waste <[email protected]>

---------

Signed-off-by: Electronic-Waste <[email protected]>
* update tune api for llm hyperparameters optimization

Signed-off-by: helenxie-bit <[email protected]>

* resolve conflict

Signed-off-by: helenxie-bit <[email protected]>

* fix the problem of dependency

Signed-off-by: helenxie-bit <[email protected]>

* fix the format of import statement

Signed-off-by: helenxie-bit <[email protected]>

* adjust the blank lines

Signed-off-by: helenxie-bit <[email protected]>

* delete the trainer to reuse it in Training Operator

Signed-off-by: helenxie-bit <[email protected]>

* update constants

Signed-off-by: helenxie-bit <[email protected]>

* update metrics format

Signed-off-by: helenxie-bit <[email protected]>

* update the type of  and

Signed-off-by: helenxie-bit <[email protected]>

* update the message of 'ImportError'

Signed-off-by: helenxie-bit <[email protected]>

* add TODO of PVC creation

Signed-off-by: helenxie-bit <[email protected]>

* update the name of pvc

Signed-off-by: helenxie-bit <[email protected]>

* reuse constants from Training Operator

Signed-off-by: helenxie-bit <[email protected]>

* keep 'parameters' and update validation

Signed-off-by: helenxie-bit <[email protected]>

* update for test

Signed-off-by: helenxie-bit <[email protected]>

* reuse 'get_container_spec' and 'get_pod_template_spec' from Training Operator

Signed-off-by: helenxie-bit <[email protected]>

* format with black

Signed-off-by: helenxie-bit <[email protected]>

* fix Lint error

Signed-off-by: helenxie-bit <[email protected]>

* fix Lint errors

Signed-off-by: helenxie-bit <[email protected]>

* delete types

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* update format

Signed-off-by: helenxie-bit <[email protected]>

* update format

Signed-off-by: helenxie-bit <[email protected]>

* fix e2e test error

Signed-off-by: helenxie-bit <[email protected]>

* add TODO

Signed-off-by: helenxie-bit <[email protected]>

* format with max line length

Signed-off-by: helenxie-bit <[email protected]>

* format docstring

Signed-off-by: helenxie-bit <[email protected]>

* update format

Signed-off-by: helenxie-bit <[email protected]>

* add helper functions

Signed-off-by: helenxie-bit <[email protected]>

* update format

Signed-off-by: helenxie-bit <[email protected]>

* update format

Signed-off-by: helenxie-bit <[email protected]>

* run test again

Signed-off-by: helenxie-bit <[email protected]>

* run test again

Signed-off-by: helenxie-bit <[email protected]>

* run test again

Signed-off-by: helenxie-bit <[email protected]>

* fix dict substitution in training_parameters

Signed-off-by: helenxie-bit <[email protected]>

* fix typo

Signed-off-by: helenxie-bit <[email protected]>

* resolve conflicts and add check for case of no parameters

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* fix flake8 error

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* update isort file to black and fix typo

Signed-off-by: helenxie-bit <[email protected]>

* modify the set of metrics format

Signed-off-by: helenxie-bit <[email protected]>

* update tune API

Signed-off-by: helenxie-bit <[email protected]>

* add types.TrainerResources class

Signed-off-by: helenxie-bit <[email protected]>

* fix flake8 error

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* resolve conflict

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* delete properties of 'TrainerResources'

Signed-off-by: helenxie-bit <[email protected]>

* fix format error

Signed-off-by: helenxie-bit <[email protected]>

* update types

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* add import of 'TrainerResources' in '__init__.py' of katib

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* revert changes and rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* check pvc and pv status of katib deployments

Signed-off-by: helenxie-bit <[email protected]>

* check pvc and pv status of katib deployments

Signed-off-by: helenxie-bit <[email protected]>

* recommit changes

Signed-off-by: helenxie-bit <[email protected]>

* update minikube version when setup

Signed-off-by: helenxie-bit <[email protected]>

* delete the code that disables formatting for the tune function

Signed-off-by: helenxie-bit <[email protected]>

* update according to andrey's feedback

Signed-off-by: helenxie-bit <[email protected]>

* add helper function in utils

Signed-off-by: helenxie-bit <[email protected]>

* fix format

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* move metrics_collector_spec back & update helper functions & add return type for helper functions

Signed-off-by: helenxie-bit <[email protected]>

* rerun tests

Signed-off-by: helenxie-bit <[email protected]>

* fix some typos

Signed-off-by: helenxie-bit <[email protected]>

* simplify the definition of 'TrainerResources'

Signed-off-by: helenxie-bit <[email protected]>

---------

Signed-off-by: helenxie-bit <[email protected]>
Signed-off-by: helenxie-bit <[email protected]>
* chore: add condition branch in requeue logic.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: add ReportObservationLog in katib_manager_util.go.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: add ReportTrialUnavailableMetrics func.

Signed-off-by: Electronic-Waste <[email protected]>

* chore: insert unavailable value into Katib DB.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: fix lint error.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: add nil condition judgement.

Signed-off-by: Electronic-Waste <[email protected]>

* fix: add nil condition judgement in trial_controller_util.go

Signed-off-by: Electronic-Waste <[email protected]>

* chore(trial): delete nil check of MC kind in the Trial controller.

Signed-off-by: Electronic-Waste <[email protected]>

* chore(trial): init MC in newFakeTrialBatchJob to avoid nil condition in trial reconcile loop.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(trial): fix lint error.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(trial): fix lint error in controller.

Signed-off-by: Electronic-Waste <[email protected]>

* test(trial): add integration test for Push MC.

Signed-off-by: Electronic-Waste <[email protected]>

* chore(trial): retry reconcilation when reporting unavailable metrics failed.

Signed-off-by: Electronic-Waste <[email protected]>

* test(trial): fix EXPECT order.

Signed-off-by: Electronic-Waste <[email protected]>

* test(trial): fix typo error.

Signed-off-by: Electronic-Waste <[email protected]>

* chore(trial): add errReportMetricsFailed.

Signed-off-by: Electronic-Waste <[email protected]>

* Update pkg/controller.v1beta1/trial/trial_controller.go

Co-authored-by: Andrey Velichkevich <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>

* Update pkg/controller.v1beta1/trial/trial_controller_util.go

Co-authored-by: Yuki Iwai <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>

* Update pkg/controller.v1beta1/trial/trial_controller.go

Co-authored-by: Yuki Iwai <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>

* fix(trial): rename errors pkg.

Signed-off-by: Electronic-Waste <[email protected]>

* test(trial): update the order of UT.

Signed-off-by: Electronic-Waste <[email protected]>

* test(trial): use different names for UTs.

Signed-off-by: Electronic-Waste <[email protected]>

* test(trial): separate Push MC UTs with original UTs.

Signed-off-by: Electronic-Waste <[email protected]>

* test(trial): fix line error with gofmt.

Signed-off-by: Electronic-Waste <[email protected]>

* test(trial): reserve one UT for Push MC.

Signed-off-by: Electronic-Waste <[email protected]>

* test(trial): fix typo error.

Signed-off-by: Electronic-Waste <[email protected]>

* test(trial): make some tiny changes.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(trial): move cancel func to t.Cleanup.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(trial): use the propagated gomega instance to improve debuggability.

Signed-off-by: Electronic-Waste <[email protected]>

* fix(trial): use gofmt to reformat code.

Signed-off-by: Electronic-Waste <[email protected]>

---------

Signed-off-by: Electronic-Waste <[email protected]>
Co-authored-by: Andrey Velichkevich <[email protected]>
Co-authored-by: Yuki Iwai <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.