Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.22 camille rebase #33

Open
wants to merge 11 commits into
base: release-1.22.9-lyft.1
Choose a base branch
from
Open

Release 1.22 camille rebase #33

wants to merge 11 commits into from

Commits on Jun 29, 2022

  1. sidecar: container ordered start/shutdown support

    @tomwans @xinyuche
    tomwans authored and xinyuche committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    f50a822 View commit details
    Browse the repository at this point in the history

  2. sidecar: kubelet: don't bother killing pods when non-sidecars are done 

    This change turns off the ability to completely kill pods when the
non-sidecars are done. This is useful for cronjobs, where the
non-sidecars finish work and exit, this code previously would clean up
the pod and its resources.

This feature was pulled in from kubernetes#75099.

This is a feature that sounds nice in practice, but its not what we
need. It seems to be a bit buggy since the Pod sandbox can
potentially be deleted and recreated during the liftime of the
Pod. That ain't good.
    @tomwans @xinyuche
    tomwans authored and xinyuche committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    ed5b3c1 View commit details
    Browse the repository at this point in the history

  3. sidecar: glog -> klog

    @tomwans @xinyuche
    tomwans authored and xinyuche committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    cc4516e View commit details
    Browse the repository at this point in the history

  4. Allow metrics to be retrieved from CRI with CRI-O 

    CRI-O properly implements the CRI interface, and therefore it is
capable of returning the container stats if being asked for.

There is no reason to keep CRI-O as a special use case that has to
be run with the legacy mode making kubelet using cadvisor on each
container.

This patch removes the hardcoded assumptions that CRI-O has cannot
handle to return containers stats through CRI.

Fixes kubernetes#73750

Signed-off-by: Sebastien Boeuf <[email protected]>
    @xinyuche
    Sebastien Boeuf authored and xinyuche committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    8417e77 View commit details
    Browse the repository at this point in the history

  5. pkg/kubelet: try restoring the container spec if its nil 

    We're not guaranteed that the pod passed in has the ContainerSpec
we're looking for. With this, we check if the pod has the container
spec, and if it doesn't, we try to recover it one more time.
    @tomwans @xinyuche
    tomwans authored and xinyuche committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    e79dd97 View commit details
    Browse the repository at this point in the history

  6. pkg/kubelet: fix 1.14 compat for container restore error text

    @paulnivin @xinyuche
    paulnivin authored and xinyuche committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    7424684 View commit details
    Browse the repository at this point in the history

  7. pkg/kubelet: fix uint64 overflow when elapsed UsageCoreNanoSeconds ex… 

    …ceeds 18446744073
    @paulnivin @xinyuche
    paulnivin authored and xinyuche committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    bdda6f1 View commit details
    Browse the repository at this point in the history

  8. do not consider exited containers when calculating nanocores

    @ashleycutalo @xinyuche
    ashleycutalo authored and xinyuche committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    ce9175f View commit details
    Browse the repository at this point in the history

  9. handle case where cpuacct is reset to 0 in a live container

    @ashleycutalo @xinyuche
    ashleycutalo authored and xinyuche committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    2347789 View commit details
    Browse the repository at this point in the history

  10. remove unnecessary line

    @ashleycutalo @xinyuche
    ashleycutalo authored and xinyuche committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    20cd2a9 View commit details
    Browse the repository at this point in the history

  11. disable klog for cadvisor.GetDirFsInfo cache miss

    @paulnivin @xinyuche
    paulnivin authored and xinyuche committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    bcce88d View commit details
    Browse the repository at this point in the history