add github action to deploy to maven central repo #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecris
force-pushed
the
gh-actions-deploy
branch
from
7a7c368
to
87d9db6
Compare
hecris
commented
Dec 3, 2021
| - name: Set up Maven Central Repository | ||
| uses: actions/setup-java@v2 | ||
| with: | ||
| java-version: '11' |
There was a problem hiding this comment.
should this be 11 or 8?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds a github action to deploy presto-gateway to maven central repo through OSSRH. this deploy is triggered when a release of presto-gateway is created.
an example of this action running: https://github.com/lyft/presto-gateway/runs/4402545044?check_suite_focus=true
(i was able to trigger this action by putting its trigger event as when a PR is made. this was for testing purposes, the trigger event should be when a new release is made. the current changes reflects that)
hand off doc:
https://docs.google.com/document/d/1qKjY4M8RSey2L-XSxs5XFZsSLlK2eOmh0aNC0AU5TRI