Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate queue based router as default & Consider backend with no worker as unhealthy #208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

okayhooni
Copy link

@okayhooni okayhooni commented Aug 12, 2023

There were valuable updates on routing logic with PrestoQueueLengthRoutingTable routing manager and PrestoQueueLengthChecker observer, like below.

But, current codebase in this repository don't use both PrestoQueueLengthRoutingTable and PrestoQueueLengthChecker. And besides, there is no option to activate those useful features without code modification.

I think, there is no reason to maintain HaRoutingManager as default, because PrestoQueueLengthRoutingTable is derived from it. So, it makes sense to activate PrestoQueueLengthRoutingTable and PrestoQueueLengthChecker by default.

Plus, I add minor logic to consider cluster with no worker as unhealthy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant