Activate queue based router as default & Consider backend with no worker as unhealthy #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were valuable updates on routing logic with
PrestoQueueLengthRoutingTable
routing manager andPrestoQueueLengthChecker
observer, like below.But, current codebase in this repository don't use both
PrestoQueueLengthRoutingTable
andPrestoQueueLengthChecker
. And besides, there is no option to activate those useful features without code modification.I think, there is no reason to maintain
HaRoutingManager
as default, becausePrestoQueueLengthRoutingTable
is derived from it. So, it makes sense to activatePrestoQueueLengthRoutingTable
andPrestoQueueLengthChecker
by default.Plus, I add minor logic to consider cluster with no worker as unhealthy.