Update golangci-lint linters #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdecks
changed the title
mmorel-35
reviewed
Dec 22, 2023
| @@ -334,10 +334,10 @@ func TestPrefixedDebugger_Assert(t *testing.T) { | |||
| } | |||
|
|
|||
| d := rootDebugger{fail: fail}.Push("FIZZ") | |||
| d.Assert(1 == 1, "fizz") | |||
| d.Assert(true, "fizz") | |||
There was a problem hiding this comment.
You might be interested in adding testifylint to golangci linters .
| @@ -150,7 +150,7 @@ func TestEnum_Extension(t *testing.T) { | |||
| // cannot be parallel | |||
|
|
|||
| e := &enum{desc: &descriptor.EnumDescriptorProto{}} | |||
| assert.NotPanics(t, func() { e.Extension(nil, nil) }) | |||
| assert.NotPanics(t, func() { e.Extension(nil, nil) }) //nolint:errcheck | |||
There was a problem hiding this comment.
It's usually a best practice to exclude in golangci lint config file. You can ensure there is no nolint with nolintlint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on requested change to add
errorlintin https://github.com/lyft/protoc-gen-star/pull/124/files