Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to go modules #49

Closed

Conversation

rvolosatovs
Copy link
Contributor

@rvolosatovs rvolosatovs commented Feb 18, 2019

Switch to go modules to remove the glide dependency and simplify using of this library as a dependency.
Since the feature is opt-in in go 1.11, set GO111MODULE=on in Makefile
Merging this will break support for go versions pre-1.11
Refs #27
Closes #61

@rodaine
Copy link
Contributor

rodaine commented Feb 19, 2019

Thanks for the patch! Adding the mod files is great but please leave the glide files in place for now, we still use it internally.

@rvolosatovs
Copy link
Contributor Author

@rodaine any update on this?

@rvolosatovs
Copy link
Contributor Author

@rodaine ☝️

@rvolosatovs
Copy link
Contributor Author

Any chance this will be merged?

@tmc
Copy link

tmc commented Jul 22, 2019

Refs #61

@rvolosatovs rvolosatovs force-pushed the feature/switch-to-modules branch 2 times, most recently from bfc05fb to 1dc2c45 Compare August 19, 2019 16:58
@jasonwzm
Copy link

What is the current status of this PR?

@rvolosatovs
Copy link
Contributor Author

I haven't updated it for a while.
In case there is a real intent to merge it, I can check that everything is in order and update if necessary.

@rodaine
Copy link
Contributor

rodaine commented Nov 4, 2019

Apologies for the delay. Yes, we still want to do this. Internally, we're in the process of migrating codebases from glide -> modules, so we can't remove the glide manifests yet, but getting the modules in place as the last of 0.x and then cutting v1 with modules alone is the plan.

Let me know if you need anything from me. This week, I will be focusing on our open source tools and getting through the backlogs.

@rvolosatovs
Copy link
Contributor Author

Upgraded to Go 1.13.
Successfully rebased on latest master without merge conflicts.
Should be good to go, but I did only basic testing of the rebased version.

@rvolosatovs
Copy link
Contributor Author

@rodaine any update on this?

@wozz
Copy link

wozz commented May 26, 2020

any updates on this?

@rodaine
Copy link
Contributor

rodaine commented Aug 5, 2020

Closed by #81

@rodaine rodaine closed this Aug 5, 2020
@rvolosatovs rvolosatovs deleted the feature/switch-to-modules branch August 7, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider replacing glide with Go modules or dep
5 participants