-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to go modules #49
Switch to go modules #49
Conversation
e046baa
to
c6c66b5
Compare
Thanks for the patch! Adding the mod files is great but please leave the glide files in place for now, we still use it internally. |
c6c66b5
to
ae5df0e
Compare
ae5df0e
to
77f13f5
Compare
@rodaine any update on this? |
@rodaine ☝️ |
Any chance this will be merged? |
Refs #61 |
bfc05fb
to
1dc2c45
Compare
What is the current status of this PR? |
I haven't updated it for a while. |
Apologies for the delay. Yes, we still want to do this. Internally, we're in the process of migrating codebases from glide -> modules, so we can't remove the glide manifests yet, but getting the modules in place as the last of 0.x and then cutting v1 with modules alone is the plan. Let me know if you need anything from me. This week, I will be focusing on our open source tools and getting through the backlogs. |
1dc2c45
to
bdb7d66
Compare
Upgraded to Go 1.13. |
1dbb183
to
13e3165
Compare
@rodaine any update on this? |
any updates on this? |
Closed by #81 |
Switch to go modules to remove the
glide
dependency and simplify using of this library as a dependency.Since the feature is opt-in in
go 1.11
, setGO111MODULE=on
inMakefile
Merging this will break support for go versions pre-1.11
Refs #27
Closes #61