lang/go: Add Context.FieldType{PackageName,ImportPath} #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvolosatovs
force-pushed
the
feature/field-utils
branch
from
6271805
to
d2e00eb
Compare
rodaine
reviewed
Nov 14, 2019
| @@ -60,6 +60,16 @@ type Context interface { | |||
|
|
|||
| // OutputPath returns the output path relative to the plugin's output destination | |||
| OutputPath(entity pgs.Entity) pgs.FilePath | |||
|
|
|||
| // FieldTypeImportPath returns name of the Field type's package as it would appear in | |||
There was a problem hiding this comment.
Suggested change
| // FieldTypeImportPath returns name of the Field type's package as it would appear in | |
| // FieldTypePackageName returns name of the Field type's package as it would appear in |
rvolosatovs
force-pushed
the
feature/field-utils
branch
from
d2e00eb
to
394b726
Compare
|
Closing this since testing was never added and because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export
Context.FieldType{PackageName,ImportPath}, which can be quite useful in various scenarios.Extracted from #51