Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import path behaviour when using full path #78

Closed
wants to merge 1 commit into from
Closed

Fix import path behaviour when using full path #78

wants to merge 1 commit into from

Commits on Aug 6, 2020

  1. Fix import path behaviour when using full path 

    This change makes protoc-gen-star conform to the behaviour
of protoc-gen-go in the presence of an import_path
parameter that contains slashes.

See https://github.com/golang/protobuf/blob/v1.4.2/protoc-gen-go/generator/generator.go#L637-L643
for evidence of this behaviour in protoc-gen-go.

Fixes lyft#77
    @johanbrandhorst
    johanbrandhorst committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    9a8e34b View commit details
    Browse the repository at this point in the history