-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yamlfix 217 #219
base: main
Are you sure you want to change the base?
Yamlfix 217 #219
Conversation
|
Pull Request Test Coverage Report for Build 4056884906Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to fix all the yamls! :)
@@ -58,6 +58,7 @@ lint: | |||
pdm run flakeheaven lint src/ tests/ | |||
$(isort) --check-only --df | |||
$(black) --check --diff | |||
yamllint . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use yamlfix --check
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doh! Good idea!
on: # yamllint disable-line rule:truthy | ||
push: | ||
branches: [main] | ||
pull_request: | ||
types: [opened, synchronize] | ||
workflow_dispatch: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line length should be changed by yamlfix
too. Look at the docs. Maybe it's a bug that it's not cropping it well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't feel like debugging the issue with the cropping, you can do it manually, but I wouldn't increase the line length either in yamlfix
or in yamllint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, it must be a bug. I even tried setting that specifically and it did not work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confirmed the bug and opened a new issue to track it. I'd say it's better to manually fix these comments so that we can merge the PR. What do you think?
Fixing yaml from #217
Checklist