etcd_docker 4: Incorporate docker based etcd into Go integration tests (#4148) #4206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
branch
from
7bf60f0
to
4e40e13
Compare
This was referenced Mar 14, 2023
justinjc
approved these changes
Mar 22, 2023
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/263fed13
branch
from
780280f
to
fa338b9
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
branch
from
4e40e13
to
8277eef
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/263fed13
branch
from
fa338b9
to
8d896f4
Compare
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
branch
from
8277eef
to
71ed759
Compare
Base automatically changed from
pr/andrewmains12/amains/grpc-update/etcd_tests.review/263fed13
to
master
March 28, 2023 14:40
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
branch
from
71ed759
to
135cdd8
Compare
andrewmains12
deleted the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/3ae12ffd
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 4 for #4144
High level approach is as described in #4144 .
This PR integrates docker based etcd into our Go integration tests. It removes the need to have the embed package running
in m3db for them, but doesn't yet touch that functionality.
Stack: