Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use v1 Ingresses when available #182

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Use v1 Ingresses when available #182

merged 3 commits into from
Oct 29, 2020

Conversation

LCaparelli
Copy link
Member

Fix #180

@LCaparelli LCaparelli added the enhancement 👑 New feature or request label Oct 28, 2020
@LCaparelli LCaparelli added this to the v0.4.0 milestone Oct 28, 2020
@LCaparelli
Copy link
Member Author

LCaparelli commented Oct 28, 2020 •
edited
Loading

Actually, I just realized in the shower there's a bug in this. It's not enough to match Group and Version (as we have been doing so far). We must match Group, Version and Kind. In previous versions of K8s, such as 1.16, has k8s.io/api/networking/v1 but Ingress is not one of the available Kinds in this version.

EDIT: I fixed discovery locally, but it broke the fake client. I'll work on this tomorrow. Adding the WIP label, no review required for now.

@LCaparelli LCaparelli added the WIP 👷‍♀️ Work In Progress PR label Oct 28, 2020
ricardozanini
ricardozanini requested changes Oct 28, 2020
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments about the desing :D
Tell me what you think. I believe we can stretch the release a little bit to include this PR on 0.4.0.

Makefile Show resolved Hide resolved
controllers/nexus/resource/networking/manager.go Show resolved Hide resolved
controllers/nexus/resource/validation/validation.go Show resolved Hide resolved
@LCaparelli
Copy link
Member Author

Thanks for reviewing @ricardozanini, I just pushed another commit fixing discovery in case you want to check it out. I'll work on the suggestion :-)

@LCaparelli
Copy link
Member Author

@ricardozanini any other suggestions, concerns or nitpicks? :-)

@ricardozanini
Copy link
Member

I believe we can merge by the end of the day. Tomorrow morning I'll update the image and the manifest, so we can run the tests during the weekend to release 0.4.0.

@LCaparelli LCaparelli removed the WIP 👷‍♀️ Work In Progress PR label Oct 29, 2020
Kaitou786
Kaitou786 approved these changes Oct 29, 2020
View reviewed changes
Copy link
Collaborator

@Kaitou786 Kaitou786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice!

@ricardozanini ricardozanini merged commit 41b9b04 into m88i:main Oct 29, 2020
@ricardozanini ricardozanini mentioned this pull request Nov 1, 2020
Merged
@LCaparelli LCaparelli deleted the issue-180 branch December 22, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kaitou786 Kaitou786 Kaitou786 approved these changes

@ricardozanini ricardozanini ricardozanini approved these changes

Assignees
No one assigned
Labels
enhancement 👑 New feature or request Hacktoberfest
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

When available, use networking.k8s.io/v1 API version for Ingresses
3 participants
@LCaparelli @ricardozanini @Kaitou786