Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cython to prevent breaking thriftpy on python3.7 #1

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Added cython to prevent breaking thriftpy on python3.7 #1

merged 1 commit into from
Jul 30, 2018

Conversation

rahulkp220
Copy link
Contributor

@rahulkp220 rahulkp220 commented Jul 27, 2018

While installation, one indirect dependency package thriftpy breaks for python3.7.
Adding cython fixes the build error for the same package and allows the installation to go through.

Check out ISSUE-37 for thriftpy

@5u3it 5u3it merged commit b6f41c7 into mStakx:master Jul 30, 2018
rahulkp220 added a commit to rahulkp220/observability that referenced this pull request Jul 30, 2018
Removing `cython` from `requirements.txt` as the [PR 1](mStakx/observability-boilerplate1#1) got merged.
@kadhriesh
Copy link

kadhriesh commented Aug 16, 2019

ubuntu 19.**
python 3.7
I am trying to install happybase which depends on thriftpy2 I am getting this error when I try to install

Requirement already satisfied: cython in /home/kadhiresh/.local/lib/python3.7/site-packages (0.29.13)
Collecting thriftpy
Using cached https://files.pythonhosted.org/packages/f4/19/cca118cf7d2087310dbc8bd70dc7df0c1320f2652873a93d06d7ba356d4a/thriftpy-0.3.9.tar.gz
Requirement already satisfied: ply<4.0,>=3.4 in /usr/local/lib/python3.7/dist-packages (from thriftpy) (3.11)
Building wheels for collected packages: thriftpy
Running setup.py bdist_wheel for thriftpy ... error
Complete output from command /usr/bin/python3 -u -c "import setuptools, tokenize;file='/tmp/pip-install-acdxwdma/thriftpy/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" bdist_wheel -d /tmp/pip-wheel-_4mehqhx --python-tag cp37:
running bdist_wheel
The [wheel] section is deprecated. Use [bdist_wheel] instead.
running build
running build_py
creating build
creating build/lib.linux-x86_64-3.7
creating build/lib.linux-x86_64-3.7/thriftpy
copying thriftpy/tornado.py -> build/lib.linux-x86_64-3.7/thriftpy
copying thriftpy/server.py -> build/lib.linux-x86_64-3.7/thriftpy
copying thriftpy/init.py -> build/lib.linux-x86_64-3.7/thriftpy
copying thriftpy/hook.py -> build/lib.linux-x86_64-3.7/thriftpy
copying thriftpy/utils.py -> build/lib.linux-x86_64-3.7/thriftpy
copying thriftpy/thrift.py -> build/lib.linux-x86_64-3.7/thriftpy
copying thriftpy/rpc.py -> build/lib.linux-x86_64-3.7/thriftpy
copying thriftpy/_compat.py -> build/lib.linux-x86_64-3.7/thriftpy
creating build/lib.linux-x86_64-3.7/thriftpy/parser
copying thriftpy/parser/parser.py -> build/lib.linux-x86_64-3.7/thriftpy/parser
copying thriftpy/parser/init.py -> build/lib.linux-x86_64-3.7/thriftpy/parser
copying thriftpy/parser/exc.py -> build/lib.linux-x86_64-3.7/thriftpy/parser
copying thriftpy/parser/lexer.py -> build/lib.linux-x86_64-3.7/thriftpy/parser
creating build/lib.linux-x86_64-3.7/thriftpy/protocol
copying thriftpy/protocol/init.py -> build/lib.linux-x86_64-3.7/thriftpy/protocol
copying thriftpy/protocol/exc.py -> build/lib.linux-x86_64-3.7/thriftpy/protocol
copying thriftpy/protocol/compact.py -> build/lib.linux-x86_64-3.7/thriftpy/protocol
copying thriftpy/protocol/json.py -> build/lib.linux-x86_64-3.7/thriftpy/protocol
copying thriftpy/protocol/multiplex.py -> build/lib.linux-x86_64-3.7/thriftpy/protocol
copying thriftpy/protocol/binary.py -> build/lib.linux-x86_64-3.7/thriftpy/protocol
creating build/lib.linux-x86_64-3.7/thriftpy/transport
copying thriftpy/transport/init.py -> build/lib.linux-x86_64-3.7/thriftpy/transport
copying thriftpy/transport/_ssl.py -> build/lib.linux-x86_64-3.7/thriftpy/transport
copying thriftpy/transport/socket.py -> build/lib.linux-x86_64-3.7/thriftpy/transport
copying thriftpy/transport/sslsocket.py -> build/lib.linux-x86_64-3.7/thriftpy/transport
creating build/lib.linux-x86_64-3.7/thriftpy/contrib
copying thriftpy/contrib/init.py -> build/lib.linux-x86_64-3.7/thriftpy/contrib
creating build/lib.linux-x86_64-3.7/thriftpy/transport/memory
copying thriftpy/transport/memory/init.py -> build/lib.linux-x86_64-3.7/thriftpy/transport/memory
creating build/lib.linux-x86_64-3.7/thriftpy/transport/buffered
copying thriftpy/transport/buffered/init.py -> build/lib.linux-x86_64-3.7/thriftpy/transport/buffered
creating build/lib.linux-x86_64-3.7/thriftpy/transport/framed
copying thriftpy/transport/framed/init.py -> build/lib.linux-x86_64-3.7/thriftpy/transport/framed
creating build/lib.linux-x86_64-3.7/thriftpy/contrib/tracking
copying thriftpy/contrib/tracking/init.py -> build/lib.linux-x86_64-3.7/thriftpy/contrib/tracking
copying thriftpy/contrib/tracking/tracker.py -> build/lib.linux-x86_64-3.7/thriftpy/contrib/tracking
copying thriftpy/contrib/tracking/tracking.thrift -> build/lib.linux-x86_64-3.7/thriftpy/contrib/tracking
running build_ext
building 'thriftpy.transport.cybase' extension
creating build/temp.linux-x86_64-3.7
creating build/temp.linux-x86_64-3.7/thriftpy
creating build/temp.linux-x86_64-3.7/thriftpy/transport
x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/include/python3.7m -c thriftpy/transport/cybase.c -o build/temp.linux-x86_64-3.7/thriftpy/transport/cybase.o
thriftpy/transport/cybase.c:17:10: fatal error: Python.h: No such file or directory
#include "Python.h"
^~~~~~~~~~
compilation terminated.
error: command 'x86_64-linux-gnu-gcc' failed with exit status 1


Failed building wheel for thriftpy
Running setup.py clean for thriftpy
Failed to build thriftpy
Installing collected packages: thriftpy
Running setup.py install for thriftpy ... error
Complete output from command /usr/bin/python3 -u -c "import setuptools, tokenize;file='/tmp/pip-install-acdxwdma/thriftpy/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record /tmp/pip-record-j2iaac60/install-record.txt --single-version-externally-managed --compile --user --prefix=:
running install
running build
running build_py
creating build
creating build/lib.linux-x86_64-3.7
creating build/lib.linux-x86_64-3.7/thriftpy
copying thriftpy/tornado.py -> build/lib.linux-x86_64-3.7/thriftpy
copying thriftpy/server.py -> build/lib.linux-x86_64-3.7/thriftpy
copying thriftpy/init.py -> build/lib.linux-x86_64-3.7/thriftpy
copying thriftpy/hook.py -> build/lib.linux-x86_64-3.7/thriftpy
copying thriftpy/utils.py -> build/lib.linux-x86_64-3.7/thriftpy
copying thriftpy/thrift.py -> build/lib.linux-x86_64-3.7/thriftpy
copying thriftpy/rpc.py -> build/lib.linux-x86_64-3.7/thriftpy
copying thriftpy/_compat.py -> build/lib.linux-x86_64-3.7/thriftpy
creating build/lib.linux-x86_64-3.7/thriftpy/parser
copying thriftpy/parser/parser.py -> build/lib.linux-x86_64-3.7/thriftpy/parser
copying thriftpy/parser/init.py -> build/lib.linux-x86_64-3.7/thriftpy/parser
copying thriftpy/parser/exc.py -> build/lib.linux-x86_64-3.7/thriftpy/parser
copying thriftpy/parser/lexer.py -> build/lib.linux-x86_64-3.7/thriftpy/parser
creating build/lib.linux-x86_64-3.7/thriftpy/protocol
copying thriftpy/protocol/init.py -> build/lib.linux-x86_64-3.7/thriftpy/protocol
copying thriftpy/protocol/exc.py -> build/lib.linux-x86_64-3.7/thriftpy/protocol
copying thriftpy/protocol/compact.py -> build/lib.linux-x86_64-3.7/thriftpy/protocol
copying thriftpy/protocol/json.py -> build/lib.linux-x86_64-3.7/thriftpy/protocol
copying thriftpy/protocol/multiplex.py -> build/lib.linux-x86_64-3.7/thriftpy/protocol
copying thriftpy/protocol/binary.py -> build/lib.linux-x86_64-3.7/thriftpy/protocol
creating build/lib.linux-x86_64-3.7/thriftpy/transport
copying thriftpy/transport/init.py -> build/lib.linux-x86_64-3.7/thriftpy/transport
copying thriftpy/transport/_ssl.py -> build/lib.linux-x86_64-3.7/thriftpy/transport
copying thriftpy/transport/socket.py -> build/lib.linux-x86_64-3.7/thriftpy/transport
copying thriftpy/transport/sslsocket.py -> build/lib.linux-x86_64-3.7/thriftpy/transport
creating build/lib.linux-x86_64-3.7/thriftpy/contrib
copying thriftpy/contrib/init.py -> build/lib.linux-x86_64-3.7/thriftpy/contrib
creating build/lib.linux-x86_64-3.7/thriftpy/transport/memory
copying thriftpy/transport/memory/init.py -> build/lib.linux-x86_64-3.7/thriftpy/transport/memory
creating build/lib.linux-x86_64-3.7/thriftpy/transport/buffered
copying thriftpy/transport/buffered/init.py -> build/lib.linux-x86_64-3.7/thriftpy/transport/buffered
creating build/lib.linux-x86_64-3.7/thriftpy/transport/framed
copying thriftpy/transport/framed/init.py -> build/lib.linux-x86_64-3.7/thriftpy/transport/framed
creating build/lib.linux-x86_64-3.7/thriftpy/contrib/tracking
copying thriftpy/contrib/tracking/init.py -> build/lib.linux-x86_64-3.7/thriftpy/contrib/tracking
copying thriftpy/contrib/tracking/tracker.py -> build/lib.linux-x86_64-3.7/thriftpy/contrib/tracking
copying thriftpy/contrib/tracking/tracking.thrift -> build/lib.linux-x86_64-3.7/thriftpy/contrib/tracking
running build_ext
building 'thriftpy.transport.cybase' extension
creating build/temp.linux-x86_64-3.7
creating build/temp.linux-x86_64-3.7/thriftpy
creating build/temp.linux-x86_64-3.7/thriftpy/transport
x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/include/python3.7m -c thriftpy/transport/cybase.c -o build/temp.linux-x86_64-3.7/thriftpy/transport/cybase.o
thriftpy/transport/cybase.c:17:10: fatal error: Python.h: No such file or directory
#include "Python.h"
^~~~~~~~~~
compilation terminated.
error: command 'x86_64-linux-gnu-gcc' failed with exit status 1

I have tried both ways pip3 install cython thirftpy2
does it supports python 3.7
cython I have installed 0.29.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants