Update mantis-common 3rd party dependency specifications

chore: update 3rd party dependency specifications for mantis-common and corresponding changes to root build.gradle (issue Netflix#345)
mabelbot · Feb 28, 2023 · 4408fa0 · 4408fa0
1 parent 1de1a75
commit 4408fa0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/build.gradle b/build.gradle
@@ -63,6 +63,9 @@ ext.libraries = [
         ],
         hadoopCommon   : "org.apache.hadoop:hadoop-common:${versions.hadoop}",
         hadoopS3       : "org.apache.hadoop:hadoop-aws:${versions.hadoop}",
+        hamcrest       : "org.hamcrest:hamcrest-core:1.3",
+        jcip           : "net.jcip:jcip-annotations:1.0",
+        jctools        : "org.jctools:jctools-core:${versions.jctoolsVersion}",
         junitJupiter   : [
                 "org.junit.jupiter:junit-jupiter-api:${versions.junit5}",
                 "org.junit.jupiter:junit-jupiter-engine:${versions.junit5}",
@@ -73,10 +76,13 @@ ext.libraries = [
         mockitoCore    : "org.mockito:mockito-core:${versions.mockito}",
         mockitoCore3   : "org.mockito:mockito-core:${versions.mockito3}",
         mockneat       : "net.andreinc:mockneat:0.4.8",
+        nettyBuffer    : "io.netty:netty-buffer:${versions.nettyVersion}",
+        nettyCodec     : "io.netty:netty-codec-http:${versions.nettyVersion}",
         rxJava         : "io.reactivex:rxjava:1.3.8",
         rxNettyShaded  : "com.netflix:mantis-rxnetty:0.4.19.1",
         slf4jApi       : "org.slf4j:slf4j-api:${versions.slf4j}",
         slf4jLog4j12   : "org.slf4j:slf4j-log4j12:${versions.slf4j}",
+        snappyJava     : "org.xerial.snappy:snappy-java:${versions.snappyVersion}",
         spectatorApi   : "com.netflix.spectator:spectator-api:${versions.spectator}",
         spotifyFutures : "com.spotify:completable-futures:0.3.1",
         vavr           : "io.vavr:vavr:${versions.vavr}",

diff --git a/mantis-common/build.gradle b/mantis-common/build.gradle
@@ -24,11 +24,11 @@ ext {
 
 dependencies {
     api project(":mantis-common-serde")
-    api "io.netty:netty-codec-http:$nettyVersion"
-    api "io.netty:netty-buffer:$nettyVersion"
+    api libraries.nettyCodec
+    api libraries.nettyBuffer
     api group: 'io.netty', name: 'netty-transport-native-epoll', classifier: 'linux-x86_64', version: nettyVersion
-    api "org.xerial.snappy:snappy-java:$snappyVersion"
-    api "org.jctools:jctools-core:$jctoolsVersion"
+    api libraries.snappyJava
+    api libraries.jctools
 
     // spectatorApi should be packaged at entry point level to avoid version conflicts.
     compileOnly libraries.spectatorApi
@@ -39,11 +39,11 @@ dependencies {
     api libraries.slf4jApi
     api libraries.slf4jLog4j12
     implementation libraries.commonsIo
-    implementation 'net.jcip:jcip-annotations:1.0'
+    implementation libraries.jcip
 
     testImplementation libraries.spectatorApi
     testImplementation libraries.commonsLang3
-    testImplementation "org.hamcrest:hamcrest-core:1.3"
+    testImplementation libraries.hamcrest
     testImplementation libraries.junit4
     testImplementation libraries.mockitoCore
 }