Upgrade to Node.js v20 for the GitHub Actions Library [MABL-13559] #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryknowlton
approved these changes
May 21, 2024
jbaldassari
approved these changes
May 21, 2024
| @@ -4,7 +4,7 @@ import * as toolCache from '@actions/tool-cache'; | |||
|
|
|||
| type Option<T> = T | undefined; | |||
|
|
|||
| const REQUIRED_NODEJS_MAJOR_VERSION = 14; | |||
| const REQUIRED_NODEJS_MAJOR_VERSION = 18; | |||
There was a problem hiding this comment.
Should this be 20? Or we're saying that the min is 18, but it's compatible with up to 20?
There was a problem hiding this comment.
20 is what the GH Actions JS runs under, inside GH.
18 is what the CLI code runs under, on the system where the CLI will be installed.
These are disparate runtimes, @jbaldassari
twistedpair
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address GitHub Actions deprecation warnings around the Node.js version use to run the GitHub Action itself.
Additionally:
18