Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some wraps for 12+ functions #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Some wraps for 12+ functions #49

wants to merge 2 commits into from

Conversation

Gcenx
Copy link

@Gcenx Gcenx commented Aug 13, 2022

This could be used to resolve https://trac.macports.org/ticket/65653
main.log

@mascguy this being how I quickly resolved the build issues with the latest version of mpd without patching since were lightly to run into similar issues again

@Gcenx Gcenx force-pushed the patch-1 branch 2 times, most recently from 05c939f to 79474d8 Compare August 13, 2022 19:03
@kencu
Copy link
Contributor

kencu commented Aug 14, 2022

you might also be interested in this bit here, that jason came up with a year or two ago, along a similar vein, a few different defines:

https://github.com/macports/macports-ports/blob/14e7b489f6309d4dcdcb87648b0c4275d113a19d/graphics/materialx/files/old_appkit_compat/AppKit/AppKit.h

@Gcenx
Copy link
Author

Gcenx commented Aug 14, 2022

@kencu that's a rather good example of what I'd like todo, just want to get a good grasp on the correct way to handle things for legacy-support. Upstream wine mostly handles these things internally already but many other projects that test against the Github CI usually get built against the latest SDKs.

Expanding legacy-support to cover these things seems like a natural step.

@Gcenx Gcenx marked this pull request as draft August 14, 2022 18:25
@kencu
Copy link
Contributor

kencu commented Aug 14, 2022

@jasonliu-- The time may be ripe to get your wrappers into legacysupport now that demand is growing beyond just 2 or 3 ports?

@Gcenx Gcenx force-pushed the patch-1 branch 6 times, most recently from 6f256d5 to c80411f Compare August 14, 2022 21:08
@Gcenx Gcenx marked this pull request as ready for review August 15, 2022 14:47
@jasonliu--
Copy link

@jasonliu-- The time may be ripe to get your wrappers into legacysupport now that demand is growing beyond just 2 or 3 ports?

Yes, I agree. Once I finish up one of my clients' projects within the next week or so, I will try to do this. One thing that I'm not really sure how to do is to write some sort of test case for it, which apparently is required.

@mascguy
Copy link
Member

mascguy commented Apr 15, 2024

@jasonliu-- The time may be ripe to get your wrappers into legacysupport now that demand is growing beyond just 2 or 3 ports?

Yes, I agree. Once I finish up one of my clients' projects within the next week or so, I will try to do this. One thing that I'm not really sure how to do is to write some sort of test case for it, which apparently is required.

Jason, are you still interested in contributing this? No worries regardless, and certainly no rush... but we'd love to get this merged/resolved eventually.

Alternatively, if you're swamped with other things, perhaps we can pitch in and wrap up the work. Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants