npm portgroup: use latest LTS release for default #23658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In what way are this portgroup's defaults used by the ports that include it? It looks like by default the nodejs dependency will be added to depends_lib? If so, all ports that include the portgroup and use the defaults need to have their revision increased. |
|
@contextnerror please fix the conflicts so that this can be merged. |
|
Is this failing now because npm10 defaults to nodejs22? |
I have no idea... please either fix this PR or close it if there is no path forward. |
|
I've gotten myself into a bit of a mess with the commits so I'm going to start this one over. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type(s)
Tested on
macOS 10.14.6 18G9323 x86_64
Command Line Tools 10.3.0.0.1.1562985497
Verification
Have you
port lint --nitpick? (is this possible?)