Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

albafetch: fix build on macOS <10.9, refactor patch #24809

Conversation

aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor

Description

Tweaked the patch a bit, I'll do a PR in the upstream later.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6.8 10K549 x86_64
Xcode 3.2.6 10M2518

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@barracuda156 for port albafetch.

@macportsbot macportsbot added the maintainer: open Affects an openmaintainer port label Jul 5, 2024
Copy link
Contributor

@barracuda156 barracuda156 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this has been tested, LGTM

P. S. Title is inaccurate, it was not broken on 32-bit earlier :)

@aeiouaeiouaeiouaeiouaeiouaeiou aeiouaeiouaeiouaeiouaeiouaeiou changed the title albafetch: fix build on macOS <10.9 albafetch: fix build on macOS <10.9, refactor patch Jul 7, 2024
@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor Author

@reneeotten @herbygillot

@barracuda156
Copy link
Contributor

@aeiouaeiouaeiouaeiouaeiouaeiou While a non-functional matter, but IMO it will be still useful to have commit titles reflecting what is fixed more accurately.

Someone looking through history will assume it was broken on < 10.9 before, which is not strictly the case. What was broken is only one of 3 arches (or 2 of 4, if we assume ppc64 is buildable).

@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor Author

aeiouaeiouaeiouaeiouaeiouaeiou commented Jul 8, 2024

@barracuda156 that's why I added "refactor", let's see what the repository admins have to say about the solution.

@barracuda156
Copy link
Contributor

@aeiouaeiouaeiouaeiouaeiouaeiou I would rather see ”fix 64-bit builds on < 10.9” (or smth to the same effect), but no big deal.

@pmetzger pmetzger merged commit 2474cbb into macports:master Jul 8, 2024
3 checks passed
@aeiouaeiouaeiouaeiouaeiouaeiou aeiouaeiouaeiouaeiouaeiouaeiou deleted the albafetch-fix-mountain branch July 8, 2024 18:06
@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor Author

@barracuda156 oops, this commit was better because built binary from the packages server causes a segmentation error (MAC_OS_X_VERSION_MIN_REQUIRED should be in both parts of the code, but it was fine with the local test) :/

@barracuda156
Copy link
Contributor

@barracuda156 oops, this commit was better because built binary from the packages server causes a segmentation error (MAC_OS_X_VERSION_MIN_REQUIRED should be in both parts of the code, but it was fine with the local test) :/

@aeiouaeiouaeiouaeiouaeiouaeiou I thought it is a fairly trivial change and did not compare patch versions, but locally it works fine, at least it starts without issues, I just tried.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port
Development

Successfully merging this pull request may close these issues.

4 participants