-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
albafetch: fix build on macOS <10.9, refactor patch #24809
albafetch: fix build on macOS <10.9, refactor patch #24809
Conversation
Notifying maintainers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this has been tested, LGTM
P. S. Title is inaccurate, it was not broken on 32-bit earlier :)
a3f7081
to
056e475
Compare
@aeiouaeiouaeiouaeiouaeiouaeiou While a non-functional matter, but IMO it will be still useful to have commit titles reflecting what is fixed more accurately. Someone looking through history will assume it was broken on < 10.9 before, which is not strictly the case. What was broken is only one of 3 arches (or 2 of 4, if we assume ppc64 is buildable). |
@barracuda156 that's why I added "refactor", let's see what the repository admins have to say about the solution. |
@aeiouaeiouaeiouaeiouaeiouaeiou I would rather see ”fix 64-bit builds on < 10.9” (or smth to the same effect), but no big deal. |
@barracuda156 oops, this commit was better because built binary from the packages server causes a segmentation error ( |
@aeiouaeiouaeiouaeiouaeiouaeiou I thought it is a fairly trivial change and did not compare patch versions, but locally it works fine, at least it starts without issues, I just tried. |
Description
Tweaked the patch a bit, I'll do a PR in the upstream later.
Type(s)
Tested on
macOS 10.6.8 10K549 x86_64
Xcode 3.2.6 10M2518
Verification
Have you
port lint --nitpick
?sudo port test
?sudo port -vst install
?