Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-greenlet: fix build for powerpc #25503

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

barracuda156
Copy link
Contributor

Description

Fix this finally

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@stromnov for port py-greenlet.

@macportsbot macportsbot added type: bugfix maintainer: open Affects an openmaintainer port labels Aug 28, 2024
@barracuda156
Copy link
Contributor Author

Failure on macOS 14 CI is unrelated: it is Python 3.5–3.6 failing to build.

@barracuda156
Copy link
Contributor Author

@stromnov @reneeotten Could we merge this one?

@berg-michael
Copy link
Contributor

berg-michael commented Sep 13, 2024

I observe the same issue when building on 10.4 PPC. AFAICT almost all of the changes here are behind PPC only headers (read: shouldn't be any collateral damage to other targets).

@stromnov stromnov merged commit 5b98ea6 into macports:master Sep 13, 2024
2 of 3 checks passed
@barracuda156 barracuda156 deleted the py-greenlet branch December 14, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: bugfix
Development

Successfully merging this pull request may close these issues.

4 participants