Update ncbi_tools for macOS Sequoia

[weitzner]

• Update patch of ncbi_tools to enable compilation on macOS Sequoia - careful not to let text editor clean up whitespace!
• Removing platform from portfile, suppresses warning

NOTE - A previous PR for this fix failed spectacularly because config linted whitespace in the patch upon committing (ie after I tested it). Apologies. I committed this version via my terminal and confirmed that it patches, builds and installs correctly afterward.

Description

Make adjustments to patch file to fix warnings that are treated as errors in macOS 15.0 / Xcode 16.0.

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 15.0
Xcode 16.0

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL in commit message?
• checked your Portfile with port lint --nitpick?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?

[reneeotten]

is there no newer upstream version that has fixed some of the issues, this seems pretty old...

Since you didn't increase the "revision", the port will not be rebuild on systems where it installed previously. Is that what you want - are the patches not changing/fixing things you'd want available for everyone?
Secondly, please amend your commit message; it should follow ": short description".

[weitzner]

Thanks for taking the time to look at this, @reneeotten!

This port is the final version of the C implementation of BLAST and related tools - newer versions are written in C++ (and called things like BLAST+). The reason for keeping this version around alongside newer versions is that it produces ASCII-formatted checkpoint files (as opposed to some binary format) and there are protein modeling tools in use that require the ASCII format.

The patches only affect compilation - for instance, a function with an implicit return type of int produces an error with the compilers that ship with macOS 15 but did not in previous versions. So only new installs/migrations should need this and it can safely remain unchanged for users on earlier systems. Am I understanding correctly that not incrementing the revision will do just that? Would you consider it a better practice to increment it?

I have amended the commit message and will push those changes up right now - please let me know if I have misunderstood the formatting requirement and I will get it fixed right away!