Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xaos: restrict compilers to supported by qt64 #27298

Merged
merged 1 commit into from
Jan 7, 2025
Merged

xaos: restrict compilers to supported by qt64 #27298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions graphics/xaos/Portfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ PortGroup github 1.0
PortGroup cmake 1.1
PortGroup qt6 1.0
PortGroup legacysupport 1.1
PortGroup compiler_blacklist_versions 1.0

github.setup xaos-project XaoS 4.3.3 release-
revision 0
Expand Down Expand Up @@ -47,6 +48,9 @@ compiler.thread_local_storage yes

compiler.cxx_standard 2017

# Same as qt64
compiler.blacklist-append {clang < 1100}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would this need the same compiler as Qt 6.4 ; what is the error you're seeing if this is not set? I am pretty sure there is no need to set anything in the qt6 PortGroup for this as I fail to see why it would be related to what compiler Qt6 used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reneeotten Because it uses Qt 6 headers, and they are not compatible with Apple Clang < 1100:

In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_xaos/xaos/work/XaoS-4.3.3/src/ui-hlp/ui_helper.cpp:13:
In file included from /opt/local/libexec/qt6/lib/QtGui.framework/Headers/qclipboard.h:7:
In file included from /opt/local/libexec/qt6/lib/QtGui.framework/Headers/qtguiglobal.h:7:
In file included from /opt/local/libexec/qt6/lib/QtCore.framework/Headers/qglobal.h:98:
/opt/local/libexec/qt6/lib/QtCore.framework/Headers/qcompilerdetection.h:128:10: error: "Unsupported Apple Clang version"
#        error "Unsupported Apple Clang version"
         ^
/opt/local/libexec/qt6/lib/QtCore.framework/Headers/qcompilerdetection.h:844:4: error: "Qt6 requires Unicode string support in both the compiler and the standard library"
#  error "Qt6 requires Unicode string support in both the compiler and the standard library"
   ^
...
In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_xaos/xaos/work/build/XaoS_autogen/mocs_compilation.cpp:2:
In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_xaos/xaos/work/build/XaoS_autogen/YPKJ5OE7LN/moc_customdialog.cpp:10:
In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_graphics_xaos/xaos/work/build/XaoS_autogen/YPKJ5OE7LN/../../../XaoS-4.3.3/src/ui/customdialog.h:4:
In file included from /opt/local/libexec/qt6/lib/QtWidgets.framework/Headers/QDialog:1:
In file included from /opt/local/libexec/qt6/lib/QtWidgets.framework/Headers/qdialog.h:7:
In file included from /opt/local/libexec/qt6/lib/QtWidgets.framework/Headers/qtwidgetsglobal.h:7:
In file included from /opt/local/libexec/qt6/lib/QtGui.framework/Headers/qtguiglobal.h:7:
In file included from /opt/local/libexec/qt6/lib/QtCore.framework/Headers/qglobal.h:1403:
In file included from /opt/local/libexec/qt6/lib/QtCore.framework/Headers/qatomic.h:10:
/opt/local/libexec/qt6/lib/QtCore.framework/Headers/qbasicatomic.h:21:4: error: "Qt requires C++11 support"
#  error "Qt requires C++11 support"
   ^


cmake.module_path-append \
${qt6.dir}/lib/cmake/Qt6LinguistTools

Expand Down
Loading