Allow common music notation chord names

[enjikaka]

This rewrites the specification of chords to allow for more names than the constant. For example: maj7, dim etc. This is to easier extend with more special chords later like: 7b9, dim7, 7s9 etc without having awkwardly long constant names.

[enjikaka]

I think Prettier went wild here and changed the formatting. 🙈

[geoffreydhuyvetters]

Thanks for the PR :)

I think it might make sense to use the Airbnb code style guide here.

CHORD.minorMajor instead of Chord.MINOR_MAJOR etc...

What do you think @enjikaka?

[geoffreydhuyvetters]

reference here https://github.com/airbnb/javascript#naming--uppercase

[enjikaka]

I don't feel strongly for the casing differences.minorMajor feels closer to normal music notation; in like in maj7, add9. (If you regard the numer as the next part in camelCase). However, constants are normally WRITTEN_LIKE_THIS in JavaScript, not the place that gathers the constants (Chord in this case).

So I'm not sure what is best in this case. 🤔 Would a lot of stuff break if we changed to minorMajor?

[geoffreydhuyvetters]

I see your point, that would probably also mean we would have to change the intervals / scales etc for consistency.

I wasn't thinking about the case where you are just importing a specific chord type.

[geoffreydhuyvetters]

Had another thought about it, and how would you feel if we did it a bit more explicit like Interval for now. (not generating the object and spreading it). To maximize tree shaking and splitting all code should be statically analyzable.

I would love to look into using some codegen method to create the export files before build.

Looked into this but never got it to work 😞

Does that make sense? I really appreciate your efforts.

[enjikaka]

@duivvv I changed to that now! 👍 Did notice there are 4 flow errors related to intervals though. But maybe you're on to them?

[geoffreydhuyvetters]

I'm trying something out with babel-plugin-codegen in a different branch, will tag you there when I open the PR so we can discuss it. I might be on to something that would make it easy to maintain, allow for static exports and make it easy to add aliases (what we're trying to achieve in this PR I guess)

[geoffreydhuyvetters]

It would have the same result as above + the advantage of having all chords centralized in 1 file.