Use noConflict by default for CommonJS #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, Thomas!
When requiring a module with CommonJS style I generally assume it's not going to create any globals for me. Since I'll be assigning the required module to your own variable when requiring it anyway:
I simply tweaked it to call
noConflict
if you're requiring it.It's a silly little thing, but figured I'd propose this change if you want it. That's the pattern I've seen in other projects that do both, like backbone, etc: https://github.com/documentcloud/backbone/blob/master/backbone.js#L30