Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icrate method skips for WebKit #327

Closed
wants to merge 3 commits into from
Closed

icrate method skips for WebKit #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae1deb8
Define more impls for EncodeArguments and MessageArguments
silvanshade Jan 15, 2023
3f99eca
Add support for WebKit
silvanshade Jan 15, 2023
edb8268
Update icrate submodule
silvanshade Jan 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/header-translator/framework-includes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,5 @@
#import <AuthenticationServices/AuthenticationServices.h>

#import <Metal/Metal.h>

#import <WebKit/WebKit.h>
2 changes: 2 additions & 0 deletions crates/header-translator/src/data/WebKit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
data! {
}
1 change: 1 addition & 0 deletions crates/header-translator/src/data/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@ data! {
mod CoreData;
mod Foundation;
mod Metal;
mod WebKit;
}
21 changes: 21 additions & 0 deletions crates/header-translator/translation-config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ imports = ["AppKit", "CoreData", "Foundation"]
[library.AuthenticationServices]
imports = ["AuthenticationServices", "Foundation"]

[library.WebKit]
imports = ["WebKit", "AppKit", "Foundation"]

###
### Attributes that change a function/method's calling convention.
###
Expand Down Expand Up @@ -337,6 +340,8 @@ skipped = true
skipped = true
[protocol.NSWindowRestoration.methods.restoreWindowWithIdentifier_state_completionHandler]
skipped = true
[protocol.WebPlugInViewFactory.methods.plugInViewWithArguments]
skipped = true

# Custom implementation for now
[struct.NSRange]
Expand Down Expand Up @@ -827,3 +832,19 @@ skipped = true
skipped = true
[fn.MTLPackedFloat3Make]
skipped = true

# Needs `JSGlobalContextRef` from JavaScriptCore
[class.WebFrame.methods.globalContext]
skipped = true
# Needs `JSObjectRef` from JavaScriptCore
[class.WebScriptObject.methods.JSObject]
skipped = true

# error: translator assertion failure: invalid error nullability (left: Unspecified) (Right: Nullable)
[class.WebHistory.methods]
loadFromURL_error = { skipped = true }
saveToURL_error = { skipped = true }

[class.WKWebView.methods]
# uses `SecTrustRef` from Security.framework (not yet translated)
serverTrust = { skipped = true }
Loading