fix: update types

maelgangloff · May 3, 2024 · 9855279 · 9855279
1 parent f783407
commit 9855279
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/src/models/Calendar/HomeworkAssignment.ts b/src/models/Calendar/HomeworkAssignment.ts
@@ -6,7 +6,7 @@ export interface HomeworkAssignment {
   title: string | null
   html: string | null
   dueDateTime: string | null
-  dueDate: string | null
+  dueDate?: string | null
   done: boolean
   deliverWorkOnline: boolean
   onlineDeliveryUrl: null | string

diff --git a/src/models/Results/Evaluation.ts b/src/models/Results/Evaluation.ts
@@ -4,7 +4,7 @@ import type { Subject } from '../Common/Subject'
 
 export interface Evaluation {
   id: string
-  coefficient: number
+  coefficient: number | null
   average: number | null
   scale: number | null
   studentAverage: number | null

diff --git a/src/models/Results/EvaluationDetail.ts b/src/models/Results/EvaluationDetail.ts
@@ -7,7 +7,7 @@ export interface EvaluationDetail {
   title: string | null
   topic: string | null
   dateTime: string | null
-  coefficient: number
+  coefficient: number | null
   min: number | null
   max: number | null
   average: number | null

diff --git a/src/models/Results/EvaluationSettings.ts b/src/models/Results/EvaluationSettings.ts
@@ -11,7 +11,7 @@ export interface EvaluationSettings {
   skillsEnabled: boolean
   evaluationsDetailsAvailable: boolean
   periods: Period[]
-  skillsSetting: {
+  skillsSetting?: {
     id: string
     skillAcquisitionLevels: Array<{
       label: string

diff --git a/test/user.test.ts b/test/user.test.ts
@@ -3,9 +3,9 @@ import type { AuthConfig } from '../src/models/Common/Auth'
 import type { Evaluation, EvaluationSettings } from '../src/models/Results'
 import type { Agenda, HomeworkAssignment } from '../src/models/Calendar'
 import type { AbsenceFile } from '../src/models/SchoolLife'
+import type { SchoolInfo } from '../src/models/School'
 import { Skolengo } from '../src/index'
 import './common'
-import type { SchoolInfo } from '../src/models/School'
 
 const SKOLENGO_TOKENSET = process.env.SKOLENGO_TOKENSET
 const describeAuthenticated = SKOLENGO_TOKENSET !== undefined ? describe : describe.skip
@@ -81,7 +81,7 @@ describeAuthenticated('Test of the Skolengo API types - Authenticated user', ()
     })
 
     it('should match type Attachment[]', async () => {
-      const response = await user.getPeriodicReportsFiles()
+      const response = await user.getPeriodicReportsFiles(undefined, 2)
       for (const attachment of response) expect(attachment).toMatchSchema('Attachment')
     })
   })