Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamic includes #29

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

vinceh121
Copy link
Contributor

Description de la demande de fusion

Permet de modifier les includes afin d'être plus souple face aux caprices de Skolengo.

Type de changement

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Mon code ne met pas en danger les données personnelles des utilisateurs
  • Les noms des commits suivent la convention Conventional Commits
  • J'ai vérifié l'entièreté du code avant de le soumettre
  • J'ai mis à jour la documentation en lien avec mes commits
  • Mon code ne génère pas d'erreurs
  • J'ai ajouté les tests unitaires correspondants (dossier tests)
  • Les anciens et nouveaux tests unitaires sont validés en local

Note

Avant de fusionner cette PR, elle devra recevoir l'approbation d'au moins une des personnes suivantes :

@maelgangloff
Copy link
Owner

Hi @vinceh121,
thank you for the PR! ✨
It will soon be merged, as soon as other implementation possibilities have been swept away. 🔍

Thanks again ;)

@maelgangloff maelgangloff self-assigned this Sep 11, 2023
@maelgangloff maelgangloff added the enhancement New feature or request label Sep 11, 2023
@maelgangloff maelgangloff merged commit 5f10458 into maelgangloff:master Sep 11, 2023
1 check passed
@vinceh121 vinceh121 deleted the feat/dynamic-includes branch November 4, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants