Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change to skolengo api version 2.0.0 #30

Closed
wants to merge 6 commits into from

Conversation

NonozgYtb
Copy link
Contributor

@NonozgYtb NonozgYtb commented Sep 24, 2023

Description de la demande de fusion

Changement les différentes routes pour la version 2.0.0 de l'api Skolengo (disponible sur cette page)

Type de changement

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Mon code ne met pas en danger les données personnelles des utilisateurs
  • Les noms des commits suivent la convention Conventional Commits
  • J'ai vérifié l'entièreté du code avant de le soumettre
  • J'ai mis à jour la documentation en lien avec mes commits
  • Mon code ne génère pas d'erreurs
  • J'ai ajouté les tests unitaires correspondants (dossier tests)
  • Les anciens et nouveaux tests unitaires sont validés en local

Note

Avant de fusionner cette PR, elle devra recevoir l'approbation d'au moins une des personnes suivantes :

@NonozgYtb
Copy link
Contributor Author

Enfin les tests qui passent !

@maelgangloff
Copy link
Owner

Hi @NonozgYtb, thank you for your PR !

I'm sorry but this PR is too long and we don't understand what improvements you made.
If you wish to contribute, I invite you to split your work into several PR.
(In fact, don't modify the linting at the same time as you develop new features 🧑‍💻).

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants