Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Lesson model #32

Closed
wants to merge 1 commit into from
Closed

Conversation

maelgangloff
Copy link
Owner

@maelgangloff maelgangloff commented Oct 7, 2023

Description de la demande de fusion

Modification du client pour prendre en charge les derniers changements de l'API.
Les tests unitaires devront être mis à jour pour correspondre aux Types des réponses.

Type de changement

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Mon code ne met pas en danger les données personnelles des utilisateurs
  • Les noms des commits suivent la convention Conventional Commits
  • J'ai vérifié l'entièreté du code avant de le soumettre
  • J'ai mis à jour la documentation en lien avec mes commits
  • Mon code ne génère pas d'erreurs
  • J'ai ajouté les tests unitaires correspondants (dossier tests)
  • Les anciens et nouveaux tests unitaires sont validés en local

Note

Avant de fusionner cette PR, elle devra recevoir l'approbation d'au moins une des personnes suivantes :

@maelgangloff maelgangloff self-assigned this Oct 7, 2023
@maelgangloff maelgangloff added the enhancement New feature or request label Oct 7, 2023
attachments?: Attachment[]
teacher?: User
submissionAllowed: null | any
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est un booléen

@@ -13,9 +14,18 @@ export interface Lesson {
endDateTime: string
title: string
location: string
locationComplement: any
locationComplement?: any
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est une string

dueDate: string | null
done: boolean
deliverWorkOnline: boolean
onlineDeliveryUrl: null | string
subject: Subject
subject?: Subject
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne pense pas que c'est nullable

@maelgangloff maelgangloff deleted the feat/match-current-api branch November 2, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants