Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling for Entra ID Free Tenants #555

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

weyCC81
Copy link
Contributor

@weyCC81 weyCC81 commented Dec 3, 2024

List of Changes:

  • Edit features which are failing for Entra ID Free licensed Tenants
  • Add implementation in documentation for AllowedToSignupEmailBasedSubscriptions
  • Update Links in documentation from "portal.azure.com" to "entra.microsoft.com"
  • Skip dismissed Entra Recommendations (Example: 'passwordHashSync' was never enabled in Tenant) > Moved to Dismissed Entra Recommendations #564

@weyCC81 weyCC81 requested review from a team as code owners December 3, 2024 22:03
@merill
Copy link
Contributor

merill commented Dec 8, 2024

@weyCC81 Thanks a lot for your recent contributions.

In the future, it would really help if you can break these out in to separate PRs to make it easier to review.

@merill
Copy link
Contributor

merill commented Dec 8, 2024

In this instance. The EIDSCA tests are auto-generated and need to be updated in the code that generates the EIDSCA tests.

See here for details: https://maester.dev/docs/contributing#updating-eidsca-tests-and-documentation

Would you be able to update this PR to just have the fix for the Entra Recommendations test?

Thanks!

weyCC81 added a commit to weyCC81/ch.alweys.maester that referenced this pull request Dec 8, 2024
@weyCC81 weyCC81 changed the title Improve handling for Entra ID Free Tenants and dismissed Entra Recommendations Improve handling for Entra ID Free Tenants Dec 8, 2024
@weyCC81
Copy link
Contributor Author

weyCC81 commented Dec 9, 2024

First round: https://github.com/Cloud-Architekt/AzureAD-Attack-Defense/pull/62/commits
Second round: WIP (NotLicensedEntraIDP1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants