-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Captain Vargus Wrath to use CommanderCastFromCommandZoneValue #12324
base: master
Are you sure you want to change the base?
Update Captain Vargus Wrath to use CommanderCastFromCommandZoneValue #12324
Conversation
Subtle difference between "cast a commander from the command zone this game" and "cast your commander from the command zone this game" - does it matter for anything? |
CommanderCastFromCommandZoneValue tracks all commanders so maybe should be worded "cast a commander from the command zone this game" |
Well you can't adjust the wording to fit the effect logic. You have to look at the wording for each card used and match that. If there is a distinction, need to maintain logic for each. |
I can't find a difference in the rules so I guess we need the param. |
Looks like in xmage its only used in these cards src/mage/cards/t/ThunderclapDrake.java |
Did you want me to merge them here or just leave this for now? |
Yes, you can do it here or other PR (just make sure it’s really same - I can see only card hints text diff, but it’s fine). |
No description provided.