-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[40K] Implement The Red Terror #12647
Draft
Sidorovich77
wants to merge
3
commits into
magefree:master
Choose a base branch
from
karapuzz14:40K
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,93 @@ | ||
package mage.cards.t; | ||
|
||
import mage.MageInt; | ||
import mage.MageObject; | ||
import mage.abilities.TriggeredAbilityImpl; | ||
import mage.abilities.effects.common.counter.AddCountersSourceEffect; | ||
import mage.cards.CardImpl; | ||
import mage.cards.CardSetInfo; | ||
import mage.constants.CardType; | ||
import mage.constants.SubType; | ||
import mage.constants.SuperType; | ||
import mage.constants.Zone; | ||
import mage.counters.CounterType; | ||
import mage.game.Game; | ||
import mage.game.events.DamagedBatchAllEvent; | ||
import mage.game.events.DamagedEvent; | ||
import mage.game.events.GameEvent; | ||
|
||
import java.util.UUID; | ||
|
||
/** | ||
* @author Sidorovich77 | ||
*/ | ||
public final class TheRedTerror extends CardImpl { | ||
|
||
|
||
public TheRedTerror(UUID ownerId, CardSetInfo setInfo) { | ||
super(ownerId, setInfo, new CardType[]{CardType.CREATURE}, "{3}{R}"); | ||
|
||
this.supertype.add(SuperType.LEGENDARY); | ||
this.subtype.add(SubType.TYRANID); | ||
this.power = new MageInt(4); | ||
this.toughness = new MageInt(3); | ||
|
||
// Whenever a red source you control deals damage to one or more permanents and/or players, put a +1/+1 counter on The Red Terror. | ||
this.addAbility(new TheRedTerrorTriggeredAbility().withFlavorWord("Advanced Species")); | ||
|
||
} | ||
|
||
private TheRedTerror(final TheRedTerror card) { | ||
super(card); | ||
} | ||
|
||
@Override | ||
public TheRedTerror copy() { | ||
return new TheRedTerror(this); | ||
} | ||
} | ||
|
||
class TheRedTerrorTriggeredAbility extends TriggeredAbilityImpl { | ||
|
||
TheRedTerrorTriggeredAbility() { | ||
super(Zone.BATTLEFIELD, new AddCountersSourceEffect( | ||
CounterType.P1P1.createInstance(1), false | ||
).setText("put a +1/+1 counter on {this}")); | ||
setTriggerPhrase("Whenever a red source you control deals damage to one or more permanents and/or players, "); | ||
} | ||
|
||
private TheRedTerrorTriggeredAbility(final TheRedTerrorTriggeredAbility ability) { | ||
super(ability); | ||
} | ||
|
||
@Override | ||
public TheRedTerrorTriggeredAbility copy() { | ||
return new TheRedTerrorTriggeredAbility(this); | ||
} | ||
|
||
@Override | ||
public boolean checkEventType(GameEvent event, Game game) { | ||
return event.getType() == GameEvent.EventType.DAMAGED_BATCH_FOR_ALL; | ||
} | ||
|
||
public boolean checkTrigger(GameEvent event, Game game) { | ||
DamagedBatchAllEvent batchAllEvent = (DamagedBatchAllEvent) event; | ||
for (DamagedEvent batchAllEvent1 : batchAllEvent.getEvents()) { | ||
int damage = ((DamagedBatchAllEvent) event) | ||
.getEvents() | ||
.stream() | ||
.filter(damagedEvent -> isControlledBy(game.getControllerId(damagedEvent.getAttackerId()))) | ||
.mapToInt(GameEvent::getAmount) | ||
.sum(); | ||
if (damage < 1) { | ||
return false; | ||
} | ||
|
||
MageObject sourceObject = game.getObject(batchAllEvent1.getSourceId()); | ||
if (sourceObject != null && sourceObject.getColor(game).isRed()) { | ||
return true; | ||
} | ||
} | ||
return false; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oof, this is subtly bugged and needs its own batch event, that's a larger scope
example: multiple red sources you control simultaneously deal damage, should be a trigger for each, but they're all combined here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean it's possible to use existing events like DAMAGED_BATCH_FOR_PERMANENTS, DAMAGED_BATCH_FOR_PLAYERS? Maybe use them simultaneously? And if so, should I make a checkTrigger for each of them separately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I mean that a new batch event needs to be added to the engine, one that batches on source instead of target