Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative solution to problem of unplayable cards from target adjustment #12842

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ssk97
Copy link
Contributor

@ssk97 ssk97 commented Sep 10, 2024

#12753 was my original attempt at fixing it, but actually applying target adjusters proved overly complex and not worthwhile. We could instead make it official that target adjusters are not applied for the pre-activation target check, and adjust the ConditionalTargetAdjuster accordingly.

@xenohedron
Copy link
Contributor

I think this is a fine direction for the short-term solution.

@@ -12,6 +12,7 @@
public interface TargetAdjuster extends Serializable {

// Warning: This is not Copyable, do not use changeable data inside (only use static objects like Filter)
// Note: in playability check for cards, targets are not adjusted.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original commit 9c52dfa reverted from master due wrong usage. Current PR don’t use that code, but it have docs about skip adjusting.

  1. Is it fixed a bugs in current master code or just a refactored for better class usage?
  2. Is it require additional fixes due not working adjusters in playable check?

Copy link
Contributor Author

@ssk97 ssk97 Sep 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This fixes the same major bug as 9c52dfa, where cards that should be playable are not, such as trying to use [[Long River's Pull]] with a Gift, where the base spell's target is more restrictive than the adjusted version.
  2. There are some cases where a spell that isn't currently playable is highlighted as if it were, such as [[Bloodchief's Thirst]] if you don't have enough mana to kick it and the only creatures on the battlefield have a higher MV, but I don't think there's currently any reasonable way to do that.

@JayDi85
Copy link
Member

JayDi85 commented Sep 14, 2024

[[Bloodchief's Thirst]]

Copy link

Bloodchief's Thirst - (Gatherer) (Scryfall) (EDHREC)

{B}
Sorcery
Kicker {2}{B} (You may pay an additional {2}{B} as you cast this spell.)
Destroy target creature or planeswalker with mana value 2 or less. If this spell was kicked, instead destroy target creature or planeswalker.

@JayDi85 JayDi85 self-assigned this Sep 14, 2024
@ssk97 ssk97 mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants