Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[don’t merge] [BLB] Heirloom Epic, support AlternateManaPaymentAbility for abilities #12844

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ssk97
Copy link
Contributor

@ssk97 ssk97 commented Sep 10, 2024

This was a rather difficult card as it's the first AlternateManaPaymentAbility that applies to an activated ability rather than a spell, which required engine changes to support. In particular, I moved currentActivatingManaAbilitiesStep and related functions into StackObject rather than Spell.

@JayDi85 JayDi85 changed the title [BLB] Heirloom Epic, support AlternateManaPaymentAbility for abilities [don’t merge] [BLB] Heirloom Epic, support AlternateManaPaymentAbility for abilities Sep 10, 2024
@JayDi85
Copy link
Member

JayDi85 commented Sep 10, 2024

[[Heirloom Epic]]

Copy link

Heirloom Epic - (Gatherer) (Scryfall) (EDHREC)

{1}
Artifact
{4}, {T}: Draw a card. For each mana in this ability's activation cost, you may tap an untapped creature you control rather than pay that mana. Activate only as a sorcery.

@JayDi85 JayDi85 self-assigned this Sep 10, 2024
@xenohedron
Copy link
Contributor

@JayDi85 can you describe your concern with this one? It's been waiting for six weeks

@ssk97
Copy link
Contributor Author

ssk97 commented Nov 5, 2024

One potential issue is that since it is a static ability modifying the activated ability, cards that copy activated abilities don't get the alternative cost effect. Not sure how to reasonably deal with that issue (though it's not exactly a common interaction, I don't think that should be blocking)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants