Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix other param names at ai-jam-js demo launcher. #31

Merged
merged 3 commits into from
Mar 20, 2018

Conversation

lmartak
Copy link

@lmartak lmartak commented Mar 20, 2018

This resolves the remaining parameter name inconsistencies (can't believe I overlooked them in #30) and plugs the metronome into web app by correctly defining output port and output MIDI channel. This pushes #26 forward by means that now metronome can be heard and seen.

@adarob adarob self-requested a review March 20, 2018 22:00
Copy link
Contributor

@adarob adarob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm not sure how this got screwed up in the first place.

@adarob adarob merged commit 3ade93d into magenta:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants