This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Call setPartsToBody reliably to fix issue #5 #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #5 (other mails are blank)
For all mail other than order, invoice, shipment, creditmemo (those with attachment)
Mageplaza\EmailAttachments\Mail\Message::setPartsToBody
is never called. That's why those mails don't have a body.Longer explanation:
Problem is that line 54 from
Mageplaza\EmailAttachments\Observer\AbstractEmail
doesn't get called:So in turn
Mageplaza\EmailAttachments\Model\Mail::$templateVars
is null which makesMageplaza\EmailAttachments\Model\MailEvent
never callMageplaza\EmailAttachments\Mail\Message::setPartsToBody
(is only called if observer ran).So the instance of
Mageplaza\EmailAttachments\Mail\Message
has an element in$parts
but assetPartsToBody
never gets called$zendMessage
never gets a message body.So in effect all other mails apart from those with attachment don't have a body.