Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added public_id to returned fields in API AttendeeLookup class #3465

Merged
merged 1 commit into from
Jun 29, 2019

Conversation

KamikazeWombat
Copy link
Contributor

took 1 minute to get it to clone the repo, then another 30 to re-clone it twice while discovering how to fork it so I can actually upload and do a pull request. Please let me know if I need to change how I do this for general process or convenience or whatever.

@kitsuta
Copy link
Member

kitsuta commented Jun 29, 2019

First, congrats on your first pull request! 🎉

As for process, we normally point people to our reggie-formula repository, which has instructions on setting up your own development environment where you can test changes. Unfortunately, it's currently Extremely Busted, to the point where we're seriously discussing changing our whole deployment process. This also why the Travis check currently fails on all PRs. It's a bad time. 😰

Anyway, forking it is correct! You can actually also use GitHub's built-in web editor to make small changes -- it's not as nice as a proper IDE but it can be faster than changing it locally, committing it, and then making a PR.

I'm pretty sure this change is fine, but we'll go ahead and test it in staging after merging.

@kitsuta kitsuta merged commit a64696c into magfest:master Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants