Fixes for refunds and validations #4254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge MAGFest code and update dealer prereg
Fix blocking bugs for dealer reg testing
Adds a way to prevent early deletion of badges that were registered before a certain date to account for the stoppage we had after prereg.
Yes I'm a perfectionist.
Requested via Slack
Part 1 of 2 of a fix for attendee login
Part 2 of fixing attendee account login
whoops
Merge changes for prereg and hotel lottery launch
Whatever I did before caused way too many problems, so now we are using the old normalized emails for attendee accounts again. This should hopefully stop creating multiple accounts with different cases.
Add old normalization back into attendee accounts
This mostly involves making all the shared pages compatible with bootstrap 3. I had also accidentally removed all the fields for creating a new badge. Also includes unapproved dealers in the attendee search.
Get art show applications working
This attempts to fix https://jira.furfest.org/projects/SEI_SD/queues/custom/66/SEI_SD-1255 but I'm not sure if it's reproducible with unsettled transactions so I'm leaving some debug logging in. Also fixes an issue where credits offered a refund button, which makes no sense. Also distinguishes between voids and refunds in the message to admins.
Refund-related fixes and debugging
It turns out that the real problem was refunding an attendee that was marked as "paid" -- the part of the code that changed their payment status caused a session item conflict. Fixes that and cleans up a few of the other reg admin functions to make sure they work, like comp and refund. Also actually fixes the AuthNet payment button, which somehow got unfixed even though I swear I committed that change.
no, I'm not bitter at all
"Purchased" will now always say "Last Year" for any imported badges. Also reorders badges so that you see pending badges first if you have no valid badges.
Various payment and miscellaneous fixes for Registration
I didn't notice that I was using normalized_rmail for a new account rather than a search, causing an error if you tried to make a new account.
Changing several logs to DEBUG level so we can stop filling up the server with email logs
These validations are built solely for the prereg page , so we now ignore them for any attendee that isn't new or pending.
We've had this feature off for MAGFest for a while, so we need the clock to start later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes validations so that people trying to update attendees under 18 aren't told to select an adult badge. Also pulls in fixes from MFF for receipt management, particularly refunds. Also also re-enables automatic pending badge deletion.