Fix override price calculations #4256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where the Pay button was appearing on non-art-show pages.
We have a way to ignore currently_sending if it's been stuck for too long, but it wasn't working because any currently_sending email category was fully excluded from the list. This should fix that and prevent emails from getting indefinitely blocked.
We have a way to ignore currently_sending if it's been stuck for too long, but it wasn't working because any currently_sending email category was fully excluded from the list. This should fix that and prevent emails from getting indefinitely blocked.
We hope this is the main cause of our confirmation email woes
Fixes a 500 error that happend if there was no prior email to check against.
Fixes a 500 error on this page so people on the watchlist get slightly less stressed out.
Tries to get an 'X-Forwarded-For' value before the remote IP (which is our internal server). Also adds a debug log to test this much easier.
Fixes a 500 error when moving an account to a different email. Also fixes a logic error where SSO-based badges were erroneously allowed as many managers as they wanted, and ALWAYS moves a badge to a new account when an admin reassigns their account email, rather than only doing it when the admin is creating a new account.
Pulls in some receipt fixes from MAGFest and fixes an issue where a custom fee and default costs were BOTH being applied to a new receipt.
Art show applications shares a lot of code and pages with the admin side, so this updates all the HTML. Also fixes several bugs with adding pieces.
Our validation library actually doesn't cast the first part of an email to lowercase, so now we do that explicitly.
Adds card-body to the page and converts <br/><br/> to paragraphs. Who wrote this page? what do you mean that was me
Some of these fields, particularly on the admin side, had minor HTML issues where the existing value wasn't being displayed. Special requests was also named incorrectly so it wasn't being updated.
Our logic for custom price changes on apps/groups/attendees assumes that it's working with all parameters, not just changed ones. In order to avoid breaking more things I've moved the changed_params logic to after all the custom price logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on MFF I noticed that we'd introduced a bug in our custom price receipt updates, this should fix that. Also includes a bunch of changes for art show that we won't use.