Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Streaming Responses #4416

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Add Streaming Responses #4416

merged 1 commit into from
Oct 17, 2024

Conversation

bitbyt3r
Copy link
Member

This switches to using generators when rendering Jinja templates with the @render decorator. With that pages can be streamed to the client by setting the response.stream property to True on the exposed pageview function.

For now I'm just enabling this on the Attendee Receipt Discrepancies page until more get tested.

@bitbyt3r bitbyt3r requested a review from kitsuta October 17, 2024 05:01
Copy link
Member

@kitsuta kitsuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! If this works we can make it a decorator for high-intensity pages.

Also, wow, I forgot I'd made this page limit to 50 rows at once. It still doesn't load with even that... something is definitely up with how we query receipts.

@kitsuta kitsuta merged commit 87bde96 into main Oct 17, 2024
3 checks passed
@kitsuta kitsuta deleted the streaming_views branch October 17, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants