Update schedule changes list based on review #4435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a bunch of fixes/updates to the new schedule changes list: - No longer exports header/thumbnail for MIVS and MITS if there isn't a designated header/thumbnail - Displays old session names if the name changed, as that's how we would find the session to change in Guidebook - Changes the email address the at-con update notifications get sent to - Fixes linebreaks in data so that they render correctly on the page - Adds a link to the changes list to the top bar menu (under "Schedule") - Only shows the "View" link next to items if it goes to a public page or if you have access Unfortunately, while Guidebook only accepts XLS files and not XLSX files, our xlsxwriter library will not output XLS files. We could output CSV files instead but that invites encoding errors if anyone opens the file and saves it before importing into Guidebook, so for now we just have to resave exported files as XLS files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a bunch of fixes/updates to the new schedule changes list:
Unfortunately, while Guidebook only accepts XLS files and not XLSX files, our xlsxwriter library will not output XLS files. We could output CSV files instead but that invites encoding errors if anyone opens the file and saves it before importing into Guidebook, so for now we just have to resave exported files as XLS files.