Allow PHP 8 #201

MidnightDesign · 2020-09-17T19:38:09Z

No description provided.

composer.json

Ocramius

https://github.com/maglnet/ComposerRequireChecker/pull/201/checks?check_run_id=1252051299#step:7:10

Seems like composer.lock needs an update.

composer update nothing could suffice

MidnightDesign · 2020-10-14T18:14:16Z

https://github.com/maglnet/ComposerRequireChecker/pull/201/checks?check_run_id=1252051299#step:7:10
Seems like composer.lock needs an update.

composer update nothing could suffice

Ah, of course. I'm not used to having lockfiles in projects I contribute to.

Ocramius · 2020-10-14T18:14:40Z

Ha, need to update my own dependencies now :D

Ocramius · 2020-10-14T18:15:18Z

I'm not used to having lockfiles in projects I contribute to.

Just to be clear, those are only in place so that tools like phpcs, psalm, phpstan etc do not change randomly and report slightly different results :)

MidnightDesign · 2020-10-14T18:22:23Z

Just to be clear, those are only in place so that tools like phpcs, psalm, phpstan etc do not change randomly and report slightly different results :)

Yeah, obviously. I was thinking about this as a library, when I should have been thinking about it as a project.

martinssipenko · 2020-11-13T07:20:37Z

Any updates on this? Is there anything I could do to get this done?

Ocramius · 2020-11-13T15:50:34Z

I'd say #208 needs to happen first. What we got here is mostly dependency issues, for now.

martinssipenko · 2020-11-14T06:03:10Z

@Ocramius #208 is merged what am I missing?

Ocramius · 2020-11-28T17:55:32Z

@martinssipenko just a rebase needed now :-)

MidnightDesign · 2020-11-30T09:12:33Z

Now we're waiting on webmozarts/glob#21

Firehed · 2020-11-30T22:03:36Z

If there's a hold-up there, it seems like there's only one use of that dependency (ComposerRequireChecker\FileLocator\LocateFilesByGlobPattern) which seems like it could probably be factored out. Though I suppose it could have implications on advanced use-cases with custom configs (my gut check says they'd be rare based on the intersection of people that would use this and people with non-autoloaded source code)

Ocramius · 2020-11-30T22:20:50Z

If there's a hold-up there

PHP 8 was released last week: I'd call "hold up" when it's February/March :-)

MidnightDesign · 2020-11-30T23:37:11Z

I think @Firehed isn't completely off here. Maybe the dependency could be loosened/removed even if the pull request over there is merged. Fewer dependencies is (almost) always a good thing I think.

martinssipenko · 2021-01-14T19:13:36Z

webmozarts/glob version 4.2.0 was just erleased with suppport for PHP8. @MidnightDesign can you bump the deps please?

DanielBadura · 2021-01-15T09:24:01Z

@MidnightDesign could you add PHP8 to the matrix for the phar creation action? Then @OskarStark could test if his issue which he opened the last days is resolved via the phar that gets build in the CI process. I think this would be awesome 🥇

MidnightDesign · 2021-01-15T10:05:15Z

@MidnightDesign could you add PHP8 to the matrix for the phar creation action? Then @OskarStark could test if his issue which he opened the last days is resolved via the phar that gets build in the CI process. I think this would be awesome

You mean in the GitHub Actions config, right? Will do.

Would it be useful to add it to any other workflows? Do Psalm or PHPStan do something differently depending on the version? What about require-checker.yml?

Ocramius · 2021-01-17T19:21:06Z

require-checker.yml is quite agnostic, but needs to run on 7.x for another while...

composer.json

OskarStark · 2021-01-18T05:45:39Z

Can you help me out how to test this? Before I just installed the phar via PHIVE 🤔

Ocramius · 2021-01-18T05:47:42Z

@OskarStark make a new directory, add a composer.json with a packages section listing @MidnightDesign's branch, add the exact version as dependency and run composer update

OskarStark · 2021-01-18T07:00:23Z

I used:

{
    "name": "test/foo",
    "type": "project",
    "description": "Test",
    "license": "proprietary",
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/MidnightDesign/ComposerRequireChecker.git"
        }
    ],
    "require": {
        "maglnet/composer-require-checker": "dev-patch-1"
    }
}

->

Loading composer repositories with package information
Updating dependencies
Lock file operations: 15 installs, 0 updates, 0 removals
  - Locking maglnet/composer-require-checker (dev-patch-1 57ed1dc)
  - Locking nikic/php-parser (v4.10.4)
  - Locking psr/container (1.0.0)
  - Locking symfony/console (v5.2.1)
  - Locking symfony/polyfill-ctype (v1.22.0)
  - Locking symfony/polyfill-intl-grapheme (v1.22.0)
  - Locking symfony/polyfill-intl-normalizer (v1.22.0)
  - Locking symfony/polyfill-mbstring (v1.22.0)
  - Locking symfony/polyfill-php73 (v1.22.0)
  - Locking symfony/polyfill-php80 (v1.22.0)
  - Locking symfony/service-contracts (v2.2.0)
  - Locking symfony/string (v5.2.1)
  - Locking webmozart/assert (1.9.1)
  - Locking webmozart/glob (4.2.0)
  - Locking webmozart/path-util (2.3.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 15 installs, 0 updates, 0 removals
  - Downloading webmozart/glob (4.2.0)
  - Syncing maglnet/composer-require-checker (dev-patch-1 57ed1dc) into cache
  - Installing symfony/polyfill-ctype (v1.22.0): Extracting archive
  - Installing webmozart/assert (1.9.1): Extracting archive
  - Installing webmozart/path-util (2.3.0): Extracting archive
  - Installing webmozart/glob (4.2.0): Extracting archive
  - Installing symfony/polyfill-php80 (v1.22.0): Extracting archive
  - Installing symfony/polyfill-mbstring (v1.22.0): Extracting archive
  - Installing symfony/polyfill-intl-normalizer (v1.22.0): Extracting archive
  - Installing symfony/polyfill-intl-grapheme (v1.22.0): Extracting archive
  - Installing symfony/string (v5.2.1): Extracting archive
  - Installing psr/container (1.0.0): Extracting archive
  - Installing symfony/service-contracts (v2.2.0): Extracting archive
  - Installing symfony/polyfill-php73 (v1.22.0): Extracting archive
  - Installing symfony/console (v5.2.1): Extracting archive
  - Installing nikic/php-parser (v4.10.4): Extracting archive
  - Installing maglnet/composer-require-checker (dev-patch-1 57ed1dc): Cloning 57ed1dc74a from cache
5 package suggestions were added by new dependencies, use `composer suggest` to see details.
Generating autoload files
9 packages you are using are looking for funding.
Use the `composer fund` command to find out more!

->

~/dev/test • test/vendor/bin/composer-require-checker
ComposerRequireChecker dev-patch-1@57ed1dc74af28e5613a3f65929b39f3011c2a76b
There were no unknown symbols found.

with

~/dev/test • php -v
PHP 8.0.1 (cli) (built: Jan  8 2021 02:39:34) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.1, Copyright (c) Zend Technologies
    with Zend OPcache v8.0.1, Copyright (c), by Zend Technologies

Looks good to me 👍

Ocramius

LGTM 🚢

Ocramius · 2021-01-18T07:32:38Z

Rolling out a release ASAP

martinssipenko · 2021-01-18T08:07:48Z

@Ocramius will 3.0 phar also be available for download from releases?

Ocramius · 2021-01-18T08:09:16Z

No idea if that's automated, sorry: for now I released for the "traditional" approach, which allows most projects to start using the dependency again after upgrading to php 8

Ocramius · 2021-01-18T08:10:53Z

Ok, it requires manual steps: https://twitter.com/MaGlNet/status/1351079268831416323

I can't do a release, since my GPG key is not really part of that trust chain.

martinssipenko · 2021-01-18T08:17:15Z

All previous versions had phar files available, perhaps you could manually add them to release? This project works better if used as phar instead of composer install as it does not need to drag in unnecessary packages that often conflict with project's requirements.

Ocramius · 2021-01-18T08:18:21Z

Please re-read what I just wrote, slowly.

martinssipenko · 2021-01-18T08:19:05Z

Just read your last comment, after posting my previous one. Great! I'll keep an eye on it. Thanks!

maglnet · 2021-01-18T19:54:33Z

@martinssipenko
I just added a manually build phar file to the release:
https://github.com/maglnet/ComposerRequireChecker/releases/tag/3.0.0

martinssipenko · 2021-01-19T07:07:44Z

Thank you!

Ocramius requested changes Sep 17, 2020

View reviewed changes

composer.json Outdated Show resolved Hide resolved

MidnightDesign marked this pull request as draft September 17, 2020 21:24

iggyvolz mentioned this pull request Sep 18, 2020

Required parameter follows optional parameter #202

Closed

Firehed mentioned this pull request Sep 29, 2020

Add composer-require-checker to static analysis checks Firehed/php-library-template#1

Merged

Ocramius requested changes Oct 14, 2020

View reviewed changes

Ocramius added dependencies Pull requests that update a dependency file enhancement labels Oct 14, 2020

Ocramius added this to the 2.2.0 milestone Oct 14, 2020

Ocramius assigned MidnightDesign Oct 14, 2020

Ocramius modified the milestones: 2.2.0, 3.0.0 Nov 8, 2020

MidnightDesign added 3 commits November 30, 2020 08:44

Allow PHP 8

7e4bf64

Add PHP 8.0 to matrices in GH actions

e98c360

No need to run static analyses with different PHP versions

ba1ebc7

MidnightDesign force-pushed the patch-1 branch from 55e8f8b to ba1ebc7 Compare November 30, 2020 07:44

localheinz mentioned this pull request Dec 26, 2020

Enhancement: Run dependency analysis on PHP 8.0 ergebnis/php-package-template#618

Closed

1 task

localheinz mentioned this pull request Jan 13, 2021

PHP Warning: Undefined array key 314 in phar:///home/runner/work/cockpit/cockpit/tools/composer-require-checker/vendor/nikic/php-parser/lib/PhpParser/Lexer.php on line 293 #234

Closed

MidnightDesign added 3 commits January 14, 2021 22:04

Merge remote-tracking branch 'upstream/master' into patch-1

09dc013

Refresh composer.lock

069ca97

Require webmozart/glob 4.2

14430cb

MidnightDesign requested a review from Ocramius January 14, 2021 21:23

OskarStark approved these changes Jan 15, 2021

View reviewed changes

MidnightDesign added 2 commits January 15, 2021 11:06

Add PHP 8.0 to the matrix in phar-creation.yml

ef323af

Use the PHP version in the PHAR artifact name to avoid collisions

e58df65

MidnightDesign marked this pull request as ready for review January 15, 2021 10:52

DanielBadura suggested changes Jan 17, 2021

View reviewed changes

composer.json Outdated Show resolved Hide resolved

Require PHP 7.4 instead of 7.2 in composer.json

57ed1dc

Ocramius approved these changes Jan 18, 2021

View reviewed changes

Ocramius merged commit 2a3c2de into maglnet:master Jan 18, 2021

MidnightDesign deleted the patch-1 branch January 18, 2021 09:12

marinaglancy mentioned this pull request May 12, 2021

Validate command fails on PHP 8 moodlehq/moodle-plugin-ci#98

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow PHP 8 #201

Allow PHP 8 #201

MidnightDesign commented Sep 17, 2020

Ocramius left a comment

MidnightDesign commented Oct 14, 2020

Ocramius commented Oct 14, 2020

Ocramius commented Oct 14, 2020

MidnightDesign commented Oct 14, 2020

martinssipenko commented Nov 13, 2020

Ocramius commented Nov 13, 2020

martinssipenko commented Nov 14, 2020

Ocramius commented Nov 28, 2020

MidnightDesign commented Nov 30, 2020

Firehed commented Nov 30, 2020

Ocramius commented Nov 30, 2020

MidnightDesign commented Nov 30, 2020

martinssipenko commented Jan 14, 2021

DanielBadura commented Jan 15, 2021

MidnightDesign commented Jan 15, 2021

Ocramius commented Jan 17, 2021

OskarStark commented Jan 18, 2021

Ocramius commented Jan 18, 2021

OskarStark commented Jan 18, 2021

Ocramius left a comment

Ocramius commented Jan 18, 2021

martinssipenko commented Jan 18, 2021

Ocramius commented Jan 18, 2021

Ocramius commented Jan 18, 2021

martinssipenko commented Jan 18, 2021

Ocramius commented Jan 18, 2021

martinssipenko commented Jan 18, 2021

maglnet commented Jan 18, 2021

martinssipenko commented Jan 19, 2021

Allow PHP 8 #201

Allow PHP 8 #201

Conversation

MidnightDesign commented Sep 17, 2020

Ocramius left a comment

Choose a reason for hiding this comment

MidnightDesign commented Oct 14, 2020

Ocramius commented Oct 14, 2020

Ocramius commented Oct 14, 2020

MidnightDesign commented Oct 14, 2020

martinssipenko commented Nov 13, 2020

Ocramius commented Nov 13, 2020

martinssipenko commented Nov 14, 2020

Ocramius commented Nov 28, 2020

MidnightDesign commented Nov 30, 2020

Firehed commented Nov 30, 2020

Ocramius commented Nov 30, 2020

MidnightDesign commented Nov 30, 2020

martinssipenko commented Jan 14, 2021

DanielBadura commented Jan 15, 2021

MidnightDesign commented Jan 15, 2021

Ocramius commented Jan 17, 2021

OskarStark commented Jan 18, 2021

Ocramius commented Jan 18, 2021

OskarStark commented Jan 18, 2021

Ocramius left a comment

Choose a reason for hiding this comment

Ocramius commented Jan 18, 2021

martinssipenko commented Jan 18, 2021

Ocramius commented Jan 18, 2021

Ocramius commented Jan 18, 2021

martinssipenko commented Jan 18, 2021

Ocramius commented Jan 18, 2021

martinssipenko commented Jan 18, 2021

maglnet commented Jan 18, 2021

martinssipenko commented Jan 19, 2021