Code after removing certain smells

[CodeBreaker2712]

I have refactored the code a little. Fixed 4 implementation smells and 5 design smells as part of my university assignment. Hope you find them useful :)

[hannesbraun]

I'm sorry, but did you test your changes? Your code does not even compile... Neither is it formatted according to our style guide.

[hannesbraun]

While your code compiles now, it looks like you didn't test your changes. You broke the application. And still, the code is not formatted.
Also, the .VSCodeCounter directory should not be part of this pull request. And a lot of your refactoring just adds complexity without adding any value. Or for example why move the code for intersecting a line into the Vec3f class? That's specific to a line, so the code needs to stay there. That has nothing to do with a Vec3f.

I'll close this for now. I don't see any value in these changes.

[CodeBreaker2712]

That's fine, I understand. Thanks for consideration though.

…

On Tue, Dec 5, 2023, 4:32 PM Hannes Braun ***@***.***> wrote: While your code compiles now, it looks like you didn't test your changes. You broke the application. And still, the code is not formatted. Also, the .VSCodeCounter directory should not be part of this pull request. And a lot of your refactoring just adds complexity without adding any value. Or for example why move the code for intersecting a line into the Vec3f class? That's specific to a line, so the code needs to stay there. That has nothing to do with a Vec3f. I'll close this for now. I don't see any value in these changes. — Reply to this email directly, view it on GitHub <#135 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APGUXSGCQKR4SYID3VHBGTDYH6AEVAVCNFSM6AAAAAA75EZAN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBRGU3DQMRYHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>